Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct Scikit-learn imports #4431

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Remove direct Scikit-learn imports #4431

merged 4 commits into from
Dec 8, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Dec 7, 2021

No description provided.

@dantegd dantegd requested a review from a team as a code owner December 7, 2021 22:30
@dantegd dantegd changed the title Remove hard sklearn imports [skip-ci] Remove direct Scikit-learn imports [skip-ci] Dec 7, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 7, 2021
@dantegd dantegd changed the title Remove direct Scikit-learn imports [skip-ci] Remove direct Scikit-learn imports Dec 7, 2021
@dantegd
Copy link
Member Author

dantegd commented Dec 7, 2021

rerun tests

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Dec 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #4431 (e81f315) into branch-21.12 (e9fb48c) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #4431      +/-   ##
================================================
- Coverage         85.72%   85.72%   -0.01%     
================================================
  Files               236      236              
  Lines             19306    19318      +12     
================================================
+ Hits              16550    16560      +10     
- Misses             2756     2758       +2
Flag Coverage Δ
dask 46.53% <55.55%> (-0.01%) ⬇️
non-dask 78.61% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/multiclass/multiclass.py 84.61% <75.00%> (-0.87%) ⬇️
...party/sklearn/preprocessing/_column_transformer.py 73.76% <85.71%> (+0.07%) ⬆️
python/cuml/model_selection/__init__.py 100.00% <100.00%> (ø)
python/cuml/pipeline/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fb48c...e81f315. Read the comment docs.

@raydouglass raydouglass merged commit 4ce5bd6 into rapidsai:branch-21.12 Dec 8, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Remove direct Scikit-learn imports (rapidsai#4431)
62b8e4c 
* FIX Remove hard sklearn imports

* FIX Missing whitespace

* FIX minor error

* FIX PEP8 fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantegd @codecov-commenter @wphicks @raydouglass