Support compilation with Thrust 1.15 #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
|
@robertmaynard just a quick heads up, CI will fail for a while still, it should be fixed later today (unrelated to the changes of the PR) |
|
rerun tests |
|
@dantegd I think this ready for review/merge |
dantegd
approved these changes
Jan 10, 2022
dantegd
requested changes
Jan 10, 2022
robertmaynard
force-pushed
the
bug/compile_with_thrust_1.15
branch
from
296a257
to
5a39db8
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #4469 +/- ##
===============================================
Coverage ? 85.75%
===============================================
Files ? 236
Lines ? 19310
Branches ? 0
===============================================
Hits ? 16560
Misses ? 2750
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
robertmaynard
force-pushed
the
bug/compile_with_thrust_1.15
branch
from
5a39db8
to
3f23685
Compare
dantegd
approved these changes
Jan 12, 2022
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The following changes are required for compilation with Thrust 1.15, which is becoming the minimum required version across all of RAPIDS for 22.02. The changes needed: - Removal of global `using namespace std`. This makes calls to `cub::` ambigous as now thrust::cub ( new since 1.14? ) and cub both are valid. - Updates from rapidsai#4334, which fixes `cub::DeviceSegmentedReduce` signature changes Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are required for compilation with Thrust 1.15, which is becoming the minimum required version across all of RAPIDS for 22.02.
The changes needed:
using namespace std. This makes calls tocub::ambigous as now thrust::cub ( new since 1.14? ) and cub both are valid.cub::DeviceSegmentedReducesignature changes