Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Accept small floats in RandomForest #4717

Conversation

thomasjpfan
Copy link
Contributor

@thomasjpfan thomasjpfan requested a review from a team as a code owner April 30, 2022 03:04
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 30, 2022
@hcho3
Copy link
Contributor

hcho3 commented Apr 30, 2022

good to test

@dantegd
Copy link
Member

dantegd commented May 3, 2022

ok to test

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels May 3, 2022
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @thomasjpfan ! It looks great

@dantegd
Copy link
Member

dantegd commented May 11, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented May 11, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Merging #4717 (b05615c) into branch-22.06 (19d1afc) will decrease coverage by 7.76%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06    #4717      +/-   ##
================================================
- Coverage         96.59%   88.83%   -7.77%     
================================================
  Files               113      371     +258     
  Lines             13699    34690   +20991     
================================================
+ Hits              13233    30816   +17583     
- Misses              466     3874    +3408     
Flag Coverage Δ
dask 34.27% <0.00%> (+16.68%) ⬆️
non-dask 84.16% <100.00%> (-12.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/ensemble/randomforestclassifier.pyx 92.66% <ø> (ø)
python/cuml/ensemble/randomforestregressor.pyx 83.95% <ø> (ø)
python/cuml/ensemble/randomforest_common.pyx 92.65% <100.00%> (ø)
python/cuml/tests/test_random_forest.py 84.85% <100.00%> (+0.13%) ⬆️
python/cuml/tests/test_kernel_density.py 97.00% <0.00%> (-2.00%) ⬇️
python/cuml/tests/explainer/test_gpu_treeshap.py 98.34% <0.00%> (-0.48%) ⬇️
...omated/dask/bench_mnmg_dimensionality_reduction.py 0.00% <0.00%> (ø)
python/cuml/dask/cluster/__init__.py 100.00% <0.00%> (ø)
python/cuml/benchmark/runners.py 89.09% <0.00%> (ø)
python/cuml/cluster/agglomerative.pyx 96.47% <0.00%> (ø)
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d1afc...b05615c. Read the comment docs.

@rapids-bot rapids-bot bot merged commit a18bbd4 into rapidsai:branch-22.06 May 11, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Small min_samples_split fraction causes RandomForestRegressor.fit to fail
5 participants