Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KBinsDiscretizer bin_edges_ #4735

Merged
merged 3 commits into from
May 31, 2022
Merged

Fix KBinsDiscretizer bin_edges_ #4735

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cec1b57
Fix KBinsDiscretizer bin_edges_
viclafargue May 16, 2022
eb1d6e0
Update docstring
viclafargue May 17, 2022
841bd79
Merge branch 'branch-22.06' into fix-kbinsdiscretizer-bin-edges
viclafargue May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/cuml/_thirdparty/sklearn/preprocessing/_discretization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class KBinsDiscretizer(TransformerMixin,

"""

bin_edges_ = CumlArrayDescriptor()
bin_edges_internal_ = CumlArrayDescriptor()
n_bins_ = CumlArrayDescriptor()

@_deprecate_pos_args(version="21.06")
Expand Down Expand Up @@ -234,7 +234,7 @@ def fit(self, X, y=None) -> "KBinsDiscretizer":
'decreasing the number of bins.' % jj)
n_bins[jj] = len(bin_edges[jj]) - 1

self.bin_edges_ = bin_edges
self.bin_edges_internal_ = bin_edges
self.n_bins_ = n_bins

if 'onehot' in self.encode:
Expand Down Expand Up @@ -303,7 +303,7 @@ def transform(self, X) -> SparseCumlArray:
raise ValueError("Incorrect number of features. Expecting {}, "
"received {}.".format(n_features, Xt.shape[1]))

bin_edges = self.bin_edges_
bin_edges = self.bin_edges_internal_
for jj in range(Xt.shape[1]):
# Values which are close to a bin edge are susceptible to numeric
# instability. Add eps to X so these values are binned correctly
Expand Down Expand Up @@ -353,9 +353,13 @@ def inverse_transform(self, Xt) -> SparseCumlArray:
"received {}.".format(n_features, Xinv.shape[1]))

for jj in range(n_features):
bin_edges = self.bin_edges_[jj]
bin_edges = self.bin_edges_internal_[jj]
bin_centers = (bin_edges[1:] + bin_edges[:-1]) * 0.5
idxs = np.asnumpy(Xinv[:, jj])
Xinv[:, jj] = bin_centers[idxs.astype(np.int32)]

return Xinv

@property
def bin_edges_(self):
return self.bin_edges_internal_