-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for thrust 1.17 and fixes to accommodate for cuDF Buffer refactor #4871
Update for thrust 1.17 and fixes to accommodate for cuDF Buffer refactor #4871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions, neither of which should block the merge. Looks good!
rerun tests |
rerun tests |
1 similar comment
rerun tests |
python/cuml/common/array.py
Outdated
def host_serialize(self): | ||
"""Serialize data and metadata associated with host memory. | ||
Returns | ||
------- | ||
header : dict | ||
The metadata required to reconstruct the object. | ||
frames : list | ||
The Buffers or memoryviews that the object should contain. | ||
:meta private: | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def host_serialize(self): | |
"""Serialize data and metadata associated with host memory. | |
Returns | |
------- | |
header : dict | |
The metadata required to reconstruct the object. | |
frames : list | |
The Buffers or memoryviews that the object should contain. | |
:meta private: | |
""" | |
def host_serialize(self): | |
""" | |
Serialize data and metadata associated with host memory. | |
Returns | |
------- | |
header : dict | |
The metadata required to reconstruct the object. | |
frames : list | |
The Buffers or memoryviews that the object should contain. | |
:meta private: | |
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to fix the current error in CI:
Warning, treated as error:
/workspace/python/cuml/common/array.py:docstring of cuml.common.array.CumlArray.host_serialize:6:Unexpected indentation.
make: *** [Makefile:20: html] Error 2
rerun tests |
@@ -221,7 +221,7 @@ __global__ void excess_sample_with_replacement_kernel( | |||
// compute the adjacent differences according to the functor | |||
// TODO: Replace deprecated 'FlagHeads' with 'SubtractLeft' when it is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO: Replace deprecated 'FlagHeads' with 'SubtractLeft' when it is available |
We can remove this comment now.
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #4871 +/- ##
================================================
+ Coverage 78.02% 78.04% +0.01%
================================================
Files 180 180
Lines 11385 11421 +36
================================================
+ Hits 8883 8913 +30
- Misses 2502 2508 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@gpucibot merge |
…tor (rapidsai#4871) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#4871
…tor (#4871) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) - Victor Lafargue (https://github.com/viclafargue) URL: #4871
…tor (rapidsai#4871) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#4871
No description provided.