Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDBSCAN CPU/GPU Interop #5137

Merged
merged 2 commits into from
Jan 19, 2023
Merged

HDBSCAN CPU/GPU Interop #5137

merged 2 commits into from
Jan 19, 2023

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala requested a review from a team as a code owner January 19, 2023 15:02
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 19, 2023
@divyegala divyegala added feature request New feature or request non-breaking Non-breaking change labels Jan 19, 2023
viclafargue
viclafargue approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Approving, just added a few minor suggestions.

python/cuml/cluster/hdbscan/prediction.pyx Show resolved Hide resolved
python/cuml/cluster/hdbscan/hdbscan.pyx Show resolved Hide resolved
python/cuml/tests/test_device_selection.py Show resolved Hide resolved
python/cuml/cluster/hdbscan/hdbscan.pyx Show resolved Hide resolved
cjnolet
cjnolet approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Base: 69.63% // Head: 69.41% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (bf91538) compared to base (1bf8f57).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #5137      +/-   ##
================================================
- Coverage         69.63%   69.41%   -0.22%     
================================================
  Files               192      192              
  Lines             12523    12523              
================================================
- Hits               8720     8693      -27     
- Misses             3803     3830      +27
Impacted Files Coverage Δ
python/cuml/neighbors/kernel_density.py 72.07% <0.00%> (-15.59%) ⬇️
python/cuml/internals/array.py 86.95% <0.00%> (-1.19%) ⬇️
python/cuml/internals/import_utils.py 48.83% <0.00%> (+2.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Jan 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit bd899e1 into rapidsai:branch-23.02 Jan 19, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@divyegala
HDBSCAN CPU/GPU Interop (rapidsai#5137)
8d1a5b4 
Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@viclafargue viclafargue viclafargue approved these changes

Assignees

@divyegala divyegala

Labels
Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyegala @codecov-commenter @dantegd @cjnolet @viclafargue