Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs build GH #5155

Merged
merged 18 commits into from
Jan 31, 2023
Merged

Conversation

AjayThorve
Copy link
Member

This PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

cc @ajschmidt8

@AjayThorve AjayThorve requested review from a team as code owners January 24, 2023 22:07
@AjayThorve AjayThorve changed the title Add docs build gh Add docs build GH Jan 24, 2023
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

Just one minor request about treating warnings as errors.

cpp/Doxyfile.in Outdated Show resolved Hide resolved
AjayThorve and others added 2 commits January 25, 2023 13:58
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@ajschmidt8
Copy link
Member

@AjayThorve, pushed two minor updates to update-version.sh.

@ajschmidt8
Copy link
Member

/merge

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change needed

dependencies.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Base: 69.26% // Head: 68.88% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (8175511) compared to base (de32125).
Patch coverage: 91.11% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5155      +/-   ##
================================================
- Coverage         69.26%   68.88%   -0.39%     
================================================
  Files               192      192              
  Lines             12333    12396      +63     
================================================
- Hits               8543     8539       -4     
- Misses             3790     3857      +67     
Impacted Files Coverage Δ
python/cuml/testing/strategies.py 92.85% <90.47%> (-1.22%) ⬇️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 91.11% <100.00%> (+0.20%) ⬆️
python/cuml/feature_extraction/_vectorizers.py 84.38% <0.00%> (-5.65%) ⬇️
python/cuml/metrics/pairwise_kernels.py 75.59% <0.00%> (-5.52%) ⬇️
python/cuml/common/kernel_utils.py 91.66% <0.00%> (-4.17%) ⬇️
python/cuml/neighbors/kernel_density.py 84.41% <0.00%> (-3.25%) ⬇️
python/cuml/dask/neighbors/kneighbors_regressor.py 30.64% <0.00%> (-2.12%) ⬇️
python/cuml/dask/neighbors/nearest_neighbors.py 26.74% <0.00%> (-2.01%) ⬇️
...party/sklearn/preprocessing/_column_transformer.py 72.99% <0.00%> (-1.95%) ⬇️
...ython/cuml/dask/neighbors/kneighbors_classifier.py 21.84% <0.00%> (-1.58%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 dismissed dantegd’s stale review January 31, 2023 14:36

changes have been addressed

@rapids-bot rapids-bot bot merged commit 36e6756 into rapidsai:branch-23.02 Jan 31, 2023
@AjayThorve AjayThorve deleted the add-docs-build-GH branch January 31, 2023 16:37
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

cc @ajschmidt8

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda conda issue CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants