Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hypothesis for 23.04 #5221

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Enable hypothesis for 23.04 #5221

merged 3 commits into from
Feb 17, 2023

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Feb 9, 2023

No description provided.

@csadorf csadorf requested review from a team as code owners February 9, 2023 16:00
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 9, 2023
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Feb 9, 2023
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 10, 2023
@ajschmidt8 ajschmidt8 requested review from a team as code owners February 13, 2023 18:57
@csadorf csadorf removed request for a team February 16, 2023 07:35
@csadorf csadorf self-assigned this Feb 16, 2023
@csadorf
Revert "Disable hypothesis tests for 23.02 burndown."
8267cd9 
This reverts commit 36454fb.
@csadorf
Make running of all hypothesis phases opt in.
78907d6 
Unless the RAPIDS_CUML_RUN_HYPOTHESIS environment variable is set,
hypothesis phases are restricted to explicit examples only.
@csadorf
Apply black formatting.
45d49aa
@raydouglass
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a738de9 into rapidsai:branch-23.04 Feb 17, 2023
@csadorf csadorf deleted the enable-hypothesis-for-23.04 branch February 17, 2023 14:20
@ajschmidt8
Copy link
Member

This PR broke the nightly test workflows (see link below).

It looks like passing env to a reusable workflow is not supported.

@csadorf, can we update the HYPOTHESIS_ENABLED conditional statement to run when RAPIDS_BUILD_TYPE is nightly (like here).

@csadorf csadorf mentioned this pull request Feb 21, 2023
Merged
@csadorf
Copy link
Contributor Author

csadorf commented Feb 21, 2023

This PR broke the nightly test workflows (see link below).

It looks like passing env to a reusable workflow is not supported.

@csadorf, can we update the HYPOTHESIS_ENABLED conditional statement to run when RAPIDS_BUILD_TYPE is nightly (like here).

Thank you for pointing this out. Addressed in #5244 .

rapids-bot bot pushed a commit that referenced this pull request Feb 21, 2023
@csadorf
Enable hypothesis testing for nightly test runs. (#5244)
0eee2c6 
Partially reverts #5221.

Authors:
  - Carl Simon Adorf (https://github.com/csadorf)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@wphicks wphicks wphicks approved these changes

Assignees

@csadorf csadorf

Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csadorf @raydouglass @ajschmidt8 @wphicks