Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add custom GitHub Actions job to run clang-tidy #5235

Merged
merged 33 commits into from
Jul 13, 2023
Merged

CI: Add custom GitHub Actions job to run clang-tidy #5235

merged 33 commits into from
Jul 13, 2023

Commits on Jul 10, 2023

  1. Add gtest to common_build dependencies. 

    Needed by default unless the --nolibcumltest option is provided to the
build.sh script.
    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    6019606 View commit details
    Browse the repository at this point in the history

  2. Add nvcc to common_build dependencies.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ec724b3 View commit details
    Browse the repository at this point in the history

  3. fixup! Add gtest to common_build dependencies.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    900cf1f View commit details
    Browse the repository at this point in the history

  4. Fix bug in cpp/scripts/run-clang-tidy.py script.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    836cab3 View commit details
    Browse the repository at this point in the history

  5. Add custom GA job to run clang-tidy.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c42854c View commit details
    Browse the repository at this point in the history

  6. Update clang-tools.

    @bdice @csadorf
    bdice authored and csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e1eb1f4 View commit details
    Browse the repository at this point in the history

  7. Add cudatoolkit to clang-tidy for cuda_runtime_api.h.

    @bdice @csadorf
    bdice authored and csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7ee6d68 View commit details
    Browse the repository at this point in the history

  8. Try adding gcc to get omp.h.

    @bdice @csadorf
    bdice authored and csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4657d77 View commit details
    Browse the repository at this point in the history

  9. Apply black-formatting to run-clang-tidy.py

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    776d8ab View commit details
    Browse the repository at this point in the history

  10. Update cmake-format-rapids-cmake.json to 23.08.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0d02750 View commit details
    Browse the repository at this point in the history

  11. Remove obsolete code from ci/run_clang_tidy.sh.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    47d108a View commit details
    Browse the repository at this point in the history

  12. Revert "Try adding gcc to get omp.h." 

    This reverts commit 5ac7f9b.
    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2f19b14 View commit details
    Browse the repository at this point in the history

  13. Select build target 'libcuml'.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9be6df7 View commit details
    Browse the repository at this point in the history

  14. Remove obsolete code from run_clang_tidy.sh script.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    03580f2 View commit details
    Browse the repository at this point in the history

  15. Select clang-cpp compiler with -std=c++17 option.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    85c16e7 View commit details
    Browse the repository at this point in the history

  16. Ignore deadstores issue with c_api tests.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    5b4c816 View commit details
    Browse the repository at this point in the history

  17. Fix clang-tidy issues in experimental fil.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b3ab7af View commit details
    Browse the repository at this point in the history

  18. Adjust clang-tidy ignores.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    53fcbf9 View commit details
    Browse the repository at this point in the history

  19. Add --nobuild option to build script. 

    To enable skipping of actual builds and just invoking CMake. Used in
the context of clang-tidy.
    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2c28995 View commit details
    Browse the repository at this point in the history

  20. Handle unexpected compiler condition.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    61d0517 View commit details
    Browse the repository at this point in the history

  21. Remove debug commands.

    @csadorf
    csadorf committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e00738c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'branch-23.08' into ci-add-custom-ga-job-to-run-clang-tidy

    @csadorf
    csadorf authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6ea38ea View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Fix copyright year range on run_clang_tidy.sh.

    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b468891 View commit details
    Browse the repository at this point in the history

  2. Use ninja instead of make for clang-tidy.

    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    26cbc00 View commit details
    Browse the repository at this point in the history

  3. Rename --nobuild build option to --configure-only.

    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    058bd31 View commit details
    Browse the repository at this point in the history

  4. Allow configuration of run-clang-tidy via pyproject.toml. 

    To make it easier for developers to reproducibly run it.
    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    6c7d284 View commit details
    Browse the repository at this point in the history

  5. Add instructions on how to run clang-tidy locally. 

    Adds dedicated conda environment.
    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c4e6565 View commit details
    Browse the repository at this point in the history

  6. Return with non-zero exit code if clang-tidy is not found.

    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    403ff5c View commit details
    Browse the repository at this point in the history

  7. Adjust import order.

    @csadorf
    csadorf committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c3828a1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'branch-23.08' into ci-add-custom-ga-job-to-run-clang-tidy

    @csadorf
    csadorf authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c1da58c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge branch 'branch-23.08' into ci-add-custom-ga-job-to-run-clang-tidy

    @dantegd
    dantegd authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    b8f8aac View commit details
    Browse the repository at this point in the history

  2. Update environment file.

    @csadorf
    csadorf committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3af96ce View commit details
    Browse the repository at this point in the history

  3. Add SCCACHE_S3_NO_CREDENTIALS=1 to docker run instructions.

    @csadorf
    csadorf committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9ff16dd View commit details
    Browse the repository at this point in the history