-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported CPU/GPU operators to API docs and update docstrings #5239
Add supported CPU/GPU operators to API docs and update docstrings #5239
Conversation
@@ -341,6 +341,10 @@ class HDBSCAN(UniversalBase, ClusterMixin, CMajorInputTagMixin): | |||
(and often will) lead to some points being assigned different | |||
cluster labels between the two implementations. | |||
|
|||
This estimator supports cuML's experimental device selection capabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beckernick I'll comment again just so it's in my "reviewed" list. Feel free to delete your comment after that.
Should we maybe automatically add this comment via a common decorator? Something like @device_interop_enabled
? This would also allow us to (maybe at a later stage) set some flag that helps with testing. This could of course be done in a follow-up to not block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I agree. Doc utilities for this kind of behavior is a great idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be added to https://github.com/rapidsai/cuml/blob/branch-23.04/python/cuml/common/doc_utils.py, @beckernick could you open an issue to do it in a follow up? Thanks!
/merge |
This PR:
Module Configuration
section of the API documentation (next to the section on Verbosity Levels). As device selection capabilities can be configured, this feels like a reasonable locationThis closes #5143 and closes #5144
This is a replacement for #5150