[ENH] Add missing includes of rmm/mr/device/per_device_resource.hpp #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahendriksen
added
3 - Ready for Review
cjnolet
approved these changes
Apr 18, 2023
|
Thanks for the approval. I fear merging is blocked until the (presumably flaky(?)) unit test passes. I do not seem to be able to request a rerun of CI (I can only make status badges). Can you maybe rerun the test @cjnolet ? |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files use
rmm::mr::get_current_device_resource()but not do not includermm/mr/device/per_device_resource.hpp. This PR fixes that.The missing include was surfaced by #5363.
This PR is necessary to prevent breakage when rapidsai/raft#1415 is merged.