Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PCA test #5498

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix PCA test #5498

merged 2 commits into from
Jul 12, 2023

Conversation

viclafargue
Copy link
Contributor

Answers #5497

@viclafargue viclafargue requested a review from a team as a code owner July 11, 2023 12:18
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 11, 2023
dantegd added a commit to vyasr/cuml that referenced this pull request Jul 11, 2023
@dantegd
FIX Merge fix of PR rapidsai#5498
1d06c86
@dantegd dantegd mentioned this pull request Jul 11, 2023
Merged
@bdice
Copy link
Contributor

bdice commented Jul 11, 2023

Is this a proper fix, or just a temporary change to reduce the problem size? It appears that we have seen issues here with both CUDA 12 and CUDA 11.2. Is it hardware-dependent / taking too much memory on certain configurations? Is it just an issue with the problem size, or do we need a TODO or a new issue to investigate further?

@csadorf csadorf linked an issue Jul 11, 2023 that may be closed by this pull request
[BUG] OOM issue in test_sparse_pca_inputs in CUDA 12 conda-based pytests #5497
Closed
@bdice
Copy link
Contributor

bdice commented Jul 12, 2023

Following up: from conversations earlier today, it sounds like this is only an issue with the problem size and no additional investigation is needed.

@viclafargue
Copy link
Contributor Author

Yes, there was an issue with the test itself which was using too much GPU memory.

@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 12, 2023
csadorf
csadorf approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI passes.

@csadorf
Copy link
Contributor

csadorf commented Jul 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit b5bac91 into rapidsai:branch-23.08 Jul 12, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] OOM issue in test_sparse_pca_inputs in CUDA 12 conda-based pytests
3 participants
@viclafargue @bdice @csadorf