Support predict in MNMG Logistic Regression #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests from external contributors require approval from a |
lijinf2
changed the title
lijinf2
added
improvement
lijinf2
changed the title
cjnolet
requested changes
Jul 27, 2023
| @@ -31,7 +32,8 @@ | |||
| np = cpu_only_import("numpy") | |||
|
|
|||
|
|
|||
| class LogisticRegression(BaseEstimator, SyncFitMixinLinearModel): | |||
| # class LogisticRegression(BaseEstimator, SyncFitMixinLinearModel): | |||
There was a problem hiding this comment.
The mixins have been included in the cuml.dask.linear_model.LinearRegression. See the definition: Class LinearRegression(
BaseEstimator, SyncFitMixinLinearModel, DelayedPredictionMixin)
The next line LogisticRegression(LinearRegression) automatically inherits the two mixins, and reuses the code/functions of the LinearRegression class.
cjnolet
approved these changes
Jul 28, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
The init arguments are for LBFGS (the only algorithm in the current MNMG LogisticRegression). The key code changes should be a few lines after [PR 5516 for predict](#5516) gets merged. Key code changes can be reviewed from [here](https://github.com/rapidsai/cuml/pull/5519/files/d058d884c992661984224d0190c3bbcc0a23caf4..fbbaa5c6aef47ddc7100f5bea2a751851ca6d1b4) Authors: - Jinfeng Li (https://github.com/lijinf2) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #5519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR for PR 5477. This PR adds predict API to MNMG logistic regression and tests to verify the correctness.
Please review the code change from commit 171aef2 with message "add predict operator". The implementation is trivial after the dependency PR 5477 is merged.