Update dependencies.yaml test_notebooks to include dask_ml #5545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies.yaml test_notebooks to include dask_ml
dantegd
approved these changes
Aug 3, 2023
raydouglass
approved these changes
Aug 3, 2023
bdice
reviewed
Aug 3, 2023
dependencies.yaml
Outdated
| @@ -366,3 +366,4 @@ dependencies: | |||
| - pandas | |||
| - *scikit_learn | |||
| - seaborn | |||
| - dask_ml==2023.3.24 | |||
There was a problem hiding this comment.
I think this list is alphabetized. Let's put this at the top.
Also do we need an equality == pinning, or would it be fine to just specify the package name (or a lower bound)?
There was a problem hiding this comment.
For the release version I think it's better to make it == and the make it a lower bound for 23.10
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a missing dependency for the kmeans_mnmg_demo notebook.