Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cuml-cpu nightly #5585

Merged
merged 27 commits into from
Sep 27, 2023
Merged

Enable cuml-cpu nightly #5585

merged 27 commits into from
Sep 27, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 19, 2023 •
edited
Loading

PR Adds changes necessary to produce cum-cpu nightly packages. PR accomplishes this by:

  • Using CMake conditional compiling
  • Using Cython IF compilation temporarily. This will be changed for separating the C++ calls from the Python code, similar to pylibraft.
  • Adding new conda recipe.

Two follow ups from this are:

  • Doc and notebook updates
  • Additional models added

@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake ci labels Sep 19, 2023
@dantegd dantegd marked this pull request as ready for review September 21, 2023 20:50
@dantegd dantegd requested review from a team as code owners September 21, 2023 20:50
@dantegd dantegd added feature request New feature or request non-breaking Non-breaking change labels Sep 21, 2023
wphicks
wphicks approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dantegd dantegd added the 4 - Waiting on Author Waiting for author to respond to review label Sep 25, 2023
cjnolet
cjnolet approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of files to go through and I tried to go through them all, though it's a lot of mechanical changes so I might have missed small things.

LGTM , though

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dantegd
Copy link
Member Author

dantegd commented Sep 27, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3e5c8e9 into rapidsai:branch-23.10 Sep 27, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@raydouglass raydouglass raydouglass approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Author Waiting for author to respond to review ci CMake conda conda issue Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantegd @cjnolet @raydouglass @wphicks