Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes for early experimental support for dataframe interchange protocol API #5591

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Sep 28, 2023

PR adds some small changes that will allow us to experiment using the __dataframe__ interchange protocol API to improve support of dataframe objects and potentially simplify our management of them in a future version. Changes should not affect existing codepaths for cuDF and Pandas objects for release 23.10.

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 28, 2023
@dantegd dantegd requested a review from a team as a code owner September 28, 2023 15:13
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 28, 2023
@dantegd dantegd changed the title Add changes for early experimetnal support for dataframe interchange protocol API Add changes for early experimental support for dataframe interchange protocol API Sep 28, 2023
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the left-over debug statement and consider my suggestions, but otherwise LGTM.

Is there any way to test this?

python/cuml/internals/array.py Outdated Show resolved Hide resolved
python/cuml/internals/array.py Outdated Show resolved Hide resolved
python/cuml/internals/array.py Outdated Show resolved Hide resolved
python/cuml/internals/array.py Show resolved Hide resolved
@dantegd dantegd added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 2, 2023
@dantegd
Copy link
Member Author

dantegd commented Oct 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 83e6f4c into rapidsai:branch-23.10 Oct 3, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants