Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Nanny close timeout in LocalCUDACluster tests #5636

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Increase Nanny close timeout in LocalCUDACluster tests #5636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c3755
Increase `Nanny` close timeout in `LocalCUDACluster` tests
pentschev Oct 30, 2023
98a6047
Merge remote-tracking branch 'upstream/branch-23.12' into increase-lo…
pentschev Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/cuml/benchmark/automated/dask/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

from dask_cuda import initialize
from dask_cuda import LocalCUDACluster
from dask_cuda.utils_test import IncreasedCloseTimeoutNanny
from dask.distributed import Client

enable_tcp_over_ucx = True
Expand All @@ -28,7 +29,11 @@
@pytest.fixture(scope="module")
def cluster():

cluster = LocalCUDACluster(protocol="tcp", scheduler_port=0)
cluster = LocalCUDACluster(
protocol="tcp",
scheduler_port=0,
worker_class=IncreasedCloseTimeoutNanny,
)
yield cluster
cluster.close()

Expand All @@ -54,6 +59,7 @@ def ucx_cluster():
enable_tcp_over_ucx=enable_tcp_over_ucx,
enable_nvlink=enable_nvlink,
enable_infiniband=enable_infiniband,
worker_class=IncreasedCloseTimeoutNanny,
)
yield cluster
cluster.close()
Expand Down
8 changes: 7 additions & 1 deletion python/cuml/tests/dask/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from dask_cuda import initialize
from dask_cuda import LocalCUDACluster
from dask_cuda.utils_test import IncreasedCloseTimeoutNanny
from dask.distributed import Client

enable_tcp_over_ucx = True
Expand All @@ -14,7 +15,11 @@
@pytest.fixture(scope="module")
def cluster():

cluster = LocalCUDACluster(protocol="tcp", scheduler_port=0)
cluster = LocalCUDACluster(
protocol="tcp",
scheduler_port=0,
worker_class=IncreasedCloseTimeoutNanny,
)
yield cluster
cluster.close()

Expand All @@ -40,6 +45,7 @@ def ucx_cluster():
enable_tcp_over_ucx=enable_tcp_over_ucx,
enable_nvlink=enable_nvlink,
enable_infiniband=enable_infiniband,
worker_class=IncreasedCloseTimeoutNanny,
)
yield cluster
cluster.close()
Expand Down