Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all deprecated function calls in TUs where warnings are errors #5692

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix all deprecated function calls in TUs where warnings are errors #5692

merged 3 commits into from
Dec 7, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 7, 2023

This PR is sufficient to enable compilation in devcontainers.

Contributes to #5510

@vyasr vyasr added Tech Debt Issues related to debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 7, 2023
@vyasr vyasr self-assigned this Dec 7, 2023
@vyasr vyasr requested a review from a team as a code owner December 7, 2023 05:01
bdice
bdice approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with one minor request to refactor a fairly egregious use of using.

cpp/src/glm/qn/glm_softmax.cuh Outdated Show resolved Hide resolved
wphicks
wphicks requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this fix! This is going to make a bunch of things much, much nicer. I agree with @bdice on using and would actually like to push it a little further in this PR, but otherwise this is perfect.

cpp/src/glm/qn/glm_softmax.cuh Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from wphicks December 7, 2023 19:28
@vyasr
Copy link
Contributor Author

vyasr commented Dec 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6cd2fb3 into rapidsai:branch-24.02 Dec 7, 2023
53 checks passed
@vyasr vyasr deleted the fix/deprecated_calls branch December 8, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wphicks wphicks wphicks approved these changes

Assignees

@vyasr vyasr

Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @bdice @wphicks