Address PytestReturnNotNoneWarning in cuml tests #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
approved these changes
Mar 27, 2024
…ytestReturnNotNoneWarning
…ytestReturnNotNoneWarning
|
This is blocked on #5815 |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Apr 8, 2024
I was looking through some dask-related test failures in rapidsai/cuml#5819 and noticed that the "p2p" shuffle is causing some problems when query-planning is enabled. This PR sets the global default to "tasks". It *may* make sense to roll back this change once we fix the underlying problem(s), but I doubt it. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15469
…ytestReturnNotNoneWarning
bdice
added
bug
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Similar to #5819, pytest functions should not `return` and seems unneeded in this test Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Bradley Dice (https://github.com/bdice) URL: #5875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears in the future
pytestwill raise when a test functionreturns a nonNonevalue. There was 2 tests that had this pattern and adjusted the tests as appropriate.