Support CPU object for train_test_split
#5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
commented
Apr 29, 2024
dantegd
requested changes
Apr 30, 2024
|
|
||
| cuda = gpu_only_import_from("numba", "cuda") | ||
|
|
||
| test_array_input_types = ["numba", "cupy"] | ||
| test_array_input_types = ["numba", "cupy", "cudf", "pandas"] |
There was a problem hiding this comment.
Code looks great! But the in the tests we're only testing for dataframes, should we add tests for series as well?
There was a problem hiding this comment.
Existing tests have hardcoded 2-d array inputs that are can't be naturally cast to Series. I parametrize them with 1-d array and a fixture to convert to df / series based on data shape.
dantegd
added
improvement
dantegd
approved these changes
Apr 30, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to CPU objects for
train_test_split, leveraging theinput conversion tools defined in
input_utils.py. This PR also addsoutput_to_df_obj_likeAPI that converts CumlArray back to a series/dataframe,matching metadata from input.
In the meantime, this PR reimplements majority of
train_test_splitbycentralizing indices compute and gather. This reduces the number of kernels
launched, especially in the cases where stratify keys are provided.
Closes #5619