Add Faiss knn to cuml #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
requested changes
Oct 18, 2018
dantegd
approved these changes
Oct 18, 2018
dantegd
pushed a commit
that referenced
this pull request
Mar 1, 2019
Restoring PR218 while reverting fea-ext-svm changes
dantegd
pushed a commit
that referenced
this pull request
May 22, 2019
dantegd
pushed a commit
that referenced
this pull request
May 22, 2019
Merge pull request #7 from Salonijain27/all_tests
wphicks
pushed a commit
to wphicks/cuml
that referenced
this pull request
Oct 27, 2022
* ENH try cleaning __init__ files * ENH move device checking utilties to global_settings: * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements
ajschmidt8
pushed a commit
that referenced
this pull request
Feb 13, 2023
* ENH try cleaning __init__ files * ENH move device checking utilties to global_settings: * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements
wphicks
pushed a commit
to wphicks/cuml
that referenced
this pull request
Feb 16, 2023
* ENH try cleaning __init__ files * ENH move device checking utilties to global_settings: * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements * ENH import improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added faiss knn as a python class to cuml repo and updated cuml.pyx to import it so it can be installed with the original python setup.py install
I also added a knn_demo notebook and updated all notebooks to use from_pandas instead of the funky pd2pygdf function.