Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docs nightly #1141

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

AyodeAwe
Copy link
Contributor

This PR configures cuspatial docs builds to also run nightly (not just on PR merges only)

@AyodeAwe AyodeAwe requested a review from a team as a code owner May 17, 2023 15:59
@AyodeAwe AyodeAwe added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 17, 2023
@AyodeAwe AyodeAwe force-pushed the run-docs-nightly branch from d9abea3 to 555d241 Compare May 17, 2023 16:00
@github-actions github-actions bot added the ci label May 17, 2023
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@harrism
Copy link
Member

harrism commented May 31, 2023

@AyodeAwe @ajschmidt8 is this ready to be merged for 23.06?

@harrism harrism changed the title run docs nightly too Run docs nightly May 31, 2023
@AyodeAwe
Copy link
Contributor Author

AyodeAwe commented Jun 1, 2023

Monitoring this to get it merged today.

@AyodeAwe
Copy link
Contributor Author

AyodeAwe commented Jun 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit f07ac48 into rapidsai:branch-23.06 Jun 1, 2023
rapids-bot bot pushed a commit that referenced this pull request Aug 4, 2023
Closes #1138
Closes #1141 [here](https://github.com/rapidsai/cuspatial/pull/1156/files#diff-c522c9afb3364b1aed2b2589c0d0c260dbc634bc54844536b1d382cecb92bf29R112)
Depends on #1152
Depends on #1064

Please direct your attention [to the notebook](https://github.com/rapidsai/cuspatial/pull/1156/files#diff-cc4c516f63efa822793d75315c1b28a04bad6c9efc6fd2bdcac5cc30b05d14dd) since the dependencies and delayed state of CI issues over this week have put a lot of files into this PR.

This notebook demonstrates cuSpatial's new binary predicates on large datasets, benchmarking and comparing against the host implementation on GeoPandas.

In order to support the large inputs for these comparisons I had to reactivate the `pairwise_point_in_polygon` functionality that I'd previously written off. This is because quadtree doesn't support large N for NxN operations, since it is many-to-many, and brute-force would require a huge number of iterations to support such large dataframes. There are some more optimizations that can be made to speed up `pairwise_point_in_polygon`, but the algorithm itself isn't sufficiently fast. It is detailed fairly closely in the notebook.

Please take a look and let's have some conversations about steps forward.

Authors:
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Mark Harris (https://github.com/harrism)
  - Ray Douglass (https://github.com/raydouglass)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants