-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proj and sqlite from libcuspatial recipe. #1308
Remove proj and sqlite from libcuspatial recipe. #1308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove from dependencies.yaml: https://github.com/rapidsai/cuspatial/blob/branch-24.02/dependencies.yaml#L128 (there's a separate dependency list for cuproj https://github.com/rapidsai/cuspatial/blob/branch-24.02/dependencies.yaml#L160).
Also while doing that, we should consider pinning proj in dependencies.yaml (unless the migration is completed on cf prior to this PR merging, in which case we can remove the pinnings in this PR). |
e4adb37
to
7340b69
Compare
My concern with removing the
This is a bit confusing if the build process is separate. Perhaps we should change it to:
But that's a pretty big change. Thoughts? |
@harrism I agree that there are varying degrees of scope that this could take. Let's limit the scope in this PR and restructure parts of I think what I would propose for the second PR is:
libcuproj is header-only, so the conda package contents would be just headers (and it would define the build dependencies for those headers), like for rmm. It's also fine for us to just not have a |
I don't think this PR is going to work until the packages are restructured as discussed in the above threads. Right now cuproj is build as part of cuspatial, so the cuproj requirements are needed for the cuspatial build. You may have to do the package restructuring in order to simplify dependencies the way that you want. |
Closing as stale. I do not plan to refactor the packages as described above in the near term. |
Description
This cleans up some packaging. We no longer need
proj
orsqlite
in libcuspatial.Checklist