Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.5.1 #607

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 11, 2024
@github-actions github-actions bot added the conda label Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:27
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:27
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be updated to 12.5:

# for CUDA 12.0
conda install -c rapidsai -c conda-forge -c nvidia \
cuxfilter=24.08 python=3.10 cuda-version=12.0

(context: rapidsai/dask-cuda#1357 (review))


This one is wrong (and looks like it has been since before this PR):

cuxfilter docker example installation for cuda 12.0, ubuntu 20.04:
.. code-block:: bash
# ex. for CUDA 11.8
docker pull rapidsai/rapidsai:cuda12.0-runtime-ubuntu20.04
docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786 \
rapidsai/rapidsai:cuda11.8-runtime-ubuntu20.04

It's has a comment that says "for CUDA 11.8", but then pulls a CUDA 12.0 image, and then the docker run after that docker pull is for an 11.8 image.

The rapidsai/rapidsai image isn't updated any more. Context: rapidsai/deployment#382

Since that doc is encouraging looking at a notebook at localhost:8888, it should probably be using this image in both commands

rapidsai/notebooks:24.06-cuda12.0-py3.10

(ref: https://hub.docker.com/r/rapidsai/notebooks/tags)

I just posted a separate question (does not need to block this PR) about updating those images at rapidsai/build-planning#73.

@github-actions github-actions bot added the doc Documentation label Jul 17, 2024
@jameslamb jameslamb self-requested a review July 17, 2024 17:48
@raydouglass raydouglass removed the improvement Improvement / enhancement to an existing function label Jul 17, 2024
@jakirkham
Copy link
Member

/merge

@raydouglass raydouglass added improvement Improvement / enhancement to an existing function and removed doc Documentation labels Jul 17, 2024
@rapids-bot rapids-bot bot merged commit 5434dc3 into rapidsai:branch-24.08 Jul 17, 2024
31 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants