Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some CI versions #125

Merged
merged 1 commit into from
Jul 25, 2024
Merged

update some CI versions #125

merged 1 commit into from
Jul 25, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jul 24, 2024

Contributes to #115 .

This proposes updating some versions in CI:

  • all third-party GitHub actions to their latest versions
  • rapidsai/devcontainers image (which most CI tasks here use) from 23.10 to 24.08 (the latest)

This resolves these warnings that can be seen on every CI run (example build)

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/upload-artifact@v3

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/deploy-pages@v2

The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "github-pages", "legateboost-wheel".
Please update your workflow to use v4 of the artifact actions.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 24, 2024
@jameslamb jameslamb changed the title WIP: update some CI versions update some CI versions Jul 25, 2024
@jameslamb jameslamb marked this pull request as ready for review July 25, 2024 15:06
@jameslamb
Copy link
Member Author

I saw that copy-pr-bot is set up here.

https://github.com/rapidsai/legate-boost/blob/main/.github/copy-pr-bot.yaml

Going to try asking it to merge. That can be helpful, even for people like me with access to push the big green button, because it standardizes the commit messages.

@jameslamb
Copy link
Member Author

/merge

@jameslamb
Copy link
Member Author

welp that did not work, guess I've misunderstood something about how those pieces are connected. I'll merge this one manually.

@jameslamb jameslamb merged commit 350db47 into rapidsai:main Jul 25, 2024
3 checks passed
@jameslamb jameslamb deleted the misc/versions branch July 25, 2024 15:50
@jameslamb jameslamb mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants