-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start v24.09.00 development [skip ci] #171
Conversation
@@ -213,19 +208,21 @@ git tag -a v24.09.00 -m 'v24.09.00' | |||
git push upstream 'v24.09.00' | |||
``` | |||
|
|||
4. Update the `VERSION` file again, to the base version for the anticipated next release. Push this directly to `main`, with a commit that includes `[skip ci]` in the message so new packages will not be built from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging #169, I tried to follow these instructions. They don't work because the current branch permissions in this repo don't allow me to push directly to main
.
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
remote: error: GH013: Repository rule violations found for refs/heads/main.
remote: Review all repository rules at https://github.com/rapidsai/legate-boost/rules?ref=refs%2Fheads%2Fmain
remote:
remote: - Changes must be made through a pull request.
remote:
remote: - Required status check "pr-builder / run" is expected.
remote:
To github.com:rapidsai/legate-boost.git
! [remote rejected] main -> main (push declined due to repository rule
Honestly... that's a good thing. This PR proposes a different way to update the development version without accidentally publishing e.g. the first 24.09.00 package with a version like 24.06.01dev{n}
.
It proposes:
- opening a PR like this one
- adding
[skip ci]
to the end of the title, so merging it tomain
won't trigger a new branch build onmain
- manually pushing a tag like
v24.09.00dev
tomain
after merging
I'm going to be out until Monday... so @seberg @RAMitchell if you merge this while I'm out, can you please then immediately push a tag like that to main
?
- cunumeric {{ legate_version }} =*_gpu* | ||
- legate {{ legate_version }} =*_gpu* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*_gpu
= "ends with _gpu
"
*_gpu*
= "contains _gpu
somewhere"
I think we want that slightly more flexible form, as there's no guarantee that the packages we install will always end with _gpu
(even if the packages we currently build do).
Look at the diff from the PR that added these build string components to legate
packages... there are some other things at the end of the build strings sometimes: https://github.com/nv-legate/legate.core.internal/pull/1164/files
@@ -14,7 +14,6 @@ | |||
# '*_gpu' for systems with CUDA | |||
# | |||
# this mirrors the approach used by cunumeric / legate | |||
# (though as of 24.06, they do not append a '*_gpu' to the build string for GPU packages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Looks like the Then I pushed a new tag to the repo, following these docs. git checkout main
git pull upstream main
git tag -a v24.09.00dev -m "v24.09.00dev"
git push upstream v24.09.00dev https://github.com/rapidsai/legate-boost/releases/tag/v24.09.00dev That also did not trigger a new build, because of this regex that says "only do a new build on tags of releases" legate-boost/.github/workflows/build.yaml Lines 13 to 15 in 166c98d
I'd copied that regex from other RAPIDS repos (e.g. this cudf example). There, it serves the purpose "don't run a new build when a non-release tag is pushed". But I think here in this repo, since we'll now use a PR with |
I just deleted that git checkout main
git pull upstream main
git tag -d v24.09.00dev
git tag -a v24.09.00.dev -m "v24.09.00.dev"
git push upstream v24.09.00.dev To match the way that I'm updating the packaging stuff for this repo to reflect that, in #173. |
#163 added support for
legate
/cunumeric
24.09 nightlies here.This PR proposes the following:
legate-boost
packages as24.09.00dev{n}
legate
/cunumeric
packagesNotes for Reviewers
See inline comments for explanations of these changes.