Honor the CMAKE_CUDA_ARCHITECTURES argument.
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the default in setup.py instead of CMake scripts. - Use the more standard cmake argument instead. It helps development by accepting values like `native` and `all`.
RAMitchell
approved these changes
Dec 13, 2023
setup.py
Outdated
| @@ -26,6 +26,7 @@ | |||
|
|
|||
| cmake_flags = [ | |||
| f"-Dlegate_core_ROOT:STRING={legate_dir}", | |||
| "-DCMAKE_CUDA_ARCHITECTURES=70", # volta | |||
There was a problem hiding this comment.
Should this perhaps be native?
There was a problem hiding this comment.
That would be my preference, I just copied the default from the CMake script, will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeandall.Close #43 .