Use 64 bit CuSolver API for Eigen decomposition #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that |
Indeed, I remember discussing this very detail w/ @teju85 not too long ago. A good workaround here could be to be check the CUDA version and have the wrapper call the old version in 11.1. |
lowener
added
breaking
cjnolet
requested changes
Oct 18, 2021
cjnolet
approved these changes
Oct 22, 2021
|
rerun tests |
|
@lowener, I'm ready to merge this over but I'm waiting to see the CI pass on rapidsai/cuml#4255 first. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace the legacy call to
cusolverDnsyevjwith the 64-bit version.It also improves the indexing types used, from int to size_t when possible.