Support the concept of a patches to apply to a project built via CPM #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
|
We will want to update CPM once cpm-cmake/CPM.cmake#401 has been merged so users don't get CMake warnings after a patch has been applied. |
This will allow us to apply critical patches to projects such as thrust, and nvcomp
robertmaynard
force-pushed
the
fea/support_patching_cpm_projects
branch
from
ed06f1a
to
8ea299a
Compare
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
robertmaynard
removed
the
5 - DO NOT MERGE
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
Leverages the infrastructure of #264 to switch rapids_cpm_thrust over to using the built-in patch support. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to apply critical patches to projects such as thrust, and nvcomp