Skip to content

Commit

Permalink
Remove gtest dependency from ucxx test conda package (#223)
Browse files Browse the repository at this point in the history
Part of the effort to move all of RAPIDS over to a set of static testing / benchmarking libraries ( rapidsai/build-planning#32 ).

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #223
  • Loading branch information
robertmaynard authored Apr 23, 2024
1 parent fd2e188 commit bdd3ff9
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 52 deletions.
2 changes: 0 additions & 2 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ dependencies:
- dask-cudf==24.6.*
- doxygen=1.9.1
- fmt>=10.1.1,<11
- gmock>=1.13.0
- gtest>=1.13.0
- librmm==24.6.*
- libtool
- ninja
Expand Down
2 changes: 0 additions & 2 deletions conda/environments/all_cuda-122_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ dependencies:
- dask-cudf==24.6.*
- doxygen=1.9.1
- fmt>=10.1.1,<11
- gmock>=1.13.0
- gtest>=1.13.0
- librmm==24.6.*
- libtool
- ninja
Expand Down
4 changes: 1 addition & 3 deletions conda/recipes/ucxx/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ requirements:
- ucx
- python
- librmm =24.06
- gtest

outputs:
- name: libucxx
Expand Down Expand Up @@ -184,8 +183,7 @@ outputs:
- cuda-cudart
{% endif %}
- {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }}
- gtest
- gmock

about:
home: https://rapids.ai/
license: BSD-3-Clause
Expand Down
7 changes: 5 additions & 2 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# =================================================================================
# SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES.
# SPDX-FileCopyrightText: Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES.
# SPDX-License-Identifier: BSD 3-Clause License
# =================================================================================

Expand Down Expand Up @@ -115,7 +115,10 @@ if(UCXX_ENABLE_RMM)
endif()
# find or install GoogleTest
if(BUILD_TESTS)
include(cmake/thirdparty/get_gtest.cmake)
include(${rapids-cmake-dir}/cpm/gtest.cmake)

# Find or install GoogleTest
rapids_cpm_gtest(BUILD_STATIC)
endif()

# ##################################################################################################
Expand Down
39 changes: 0 additions & 39 deletions cpp/cmake/thirdparty/get_gtest.cmake

This file was deleted.

4 changes: 0 additions & 4 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ dependencies:
- cxx-compiler
- &cmake_ver cmake>=3.26.4
- fmt>=10.1.1,<11
- &gmock gmock>=1.13.0
- &gtest gtest>=1.13.0
- librmm==24.6.*
- ninja
- spdlog>=1.12.0,<1.13
Expand Down Expand Up @@ -250,8 +248,6 @@ dependencies:
- output_types: conda
packages:
- *cmake_ver
- *gtest
- *gmock
test_python_ucxx:
common:
- output_types: [conda, requirements, pyproject]
Expand Down

0 comments on commit bdd3ff9

Please sign in to comment.