Merge pull request #36 from ajschmidt8/update-standard

Update `CUDA_STANDARD` and `CXX_STANDARD` to `17`

cmake/Utils.cmake

@@ -170,7 +170,7 @@ function(xgboost_set_cuda_flags target)
   endif (MSVC)
 
   set_target_properties(${target} PROPERTIES
-    CUDA_STANDARD 14
+    CUDA_STANDARD 17
     CUDA_STANDARD_REQUIRED ON
     CUDA_SEPARABLE_COMPILATION OFF)
 endfunction(xgboost_set_cuda_flags)
@@ -190,7 +190,7 @@ endmacro(xgboost_link_nccl)
 # compile options
 macro(xgboost_target_properties target)
   set_target_properties(${target} PROPERTIES
-    CXX_STANDARD 14
+    CXX_STANDARD 17
     CXX_STANDARD_REQUIRED ON
     POSITION_INDEPENDENT_CODE ON)
   if (HIDE_CXX_SYMBOLS)

python-package/xgboost/core.py

@@ -229,7 +229,7 @@ def _numpy2ctypes_type(dtype):
     }
     if np.intc is not np.int32:  # Windows
         _NUMPY_TO_CTYPES_MAPPING[np.intc] = _NUMPY_TO_CTYPES_MAPPING[np.int32]
-    if dtype not in _NUMPY_TO_CTYPES_MAPPING.keys():
+    if dtype not in _NUMPY_TO_CTYPES_MAPPING:
         raise TypeError(
             f"Supported types: {_NUMPY_TO_CTYPES_MAPPING.keys()}, got: {dtype}"
         )
@@ -266,7 +266,7 @@ def ctypes2cupy(cptr, length, dtype):
     from cupy.cuda.memory import UnownedMemory
 
     CUPY_TO_CTYPES_MAPPING = {cupy.float32: ctypes.c_float, cupy.uint32: ctypes.c_uint}
-    if dtype not in CUPY_TO_CTYPES_MAPPING.keys():
+    if dtype not in CUPY_TO_CTYPES_MAPPING:
         raise RuntimeError(f"Supported types: {CUPY_TO_CTYPES_MAPPING.keys()}")
     addr = ctypes.cast(cptr, ctypes.c_void_p).value
     # pylint: disable=c-extension-no-member,no-member

python-package/xgboost/data.py

@@ -747,7 +747,7 @@ def dispatch_data_backend(
 
 def _to_data_type(dtype: str, name: str):
     dtype_map = {'float32': 1, 'float64': 2, 'uint32': 3, 'uint64': 4}
-    if dtype not in dtype_map.keys():
+    if dtype not in dtype_map:
         raise TypeError(
             f'Expecting float32, float64, uint32, uint64, got {dtype} ' +
             f'for {name}.')