Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Dockerfile and fix clippy #201

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix: update Dockerfile and fix clippy #201

merged 2 commits into from
Nov 4, 2022

Conversation

rapiz1
Copy link
Owner

@rapiz1 rapiz1 commented Nov 2, 2022

rust-musl-builder is mostly unmaintained and cargo broke things.

So our Dockerfile failed to build, as reported in #200 (comment)

This PR adopts the Dockerfile based on the official rust image rust:alpine. It builds musl by default because alpine is based on musl. It also turns off the tls feature explicitly. It never works in the docker image since missing the dynlib. Disabling the feature should give users a clear error message when trying tls.

FYI @orhun

@rapiz1 rapiz1 enabled auto-merge (squash) November 4, 2022 14:10
@rapiz1 rapiz1 changed the title fix: update Dockerfile fix: update Dockerfile and fix clippy Nov 4, 2022
@rapiz1 rapiz1 merged commit bf842b4 into main Nov 4, 2022
@rapiz1 rapiz1 deleted the fix-dockerfile branch November 4, 2022 14:39
@orhun
Copy link
Contributor

orhun commented Nov 5, 2022

Good stuff! I was aware of the issue and it is good to see an alternative MUSL build approach. Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants