Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vergen crate to support SOURCE_DATE_EPOCH #204

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Nov 6, 2022

Currently the Arch Linux package of rathole isn't reproducible: https://reproducible.archlinux.org/api/v0/builds/364854/diffoscope

This is due to the current version of vergen used in the project not respecting the SOURCE_DATE_EPOCH variable.

SOURCE_DATE_EPOCH is a standardised environment variable that distributions can set centrally and have build tools consume this in order to produce reproducible output.

Luckily, the latest version of vergen supports SOURCE_DATE_EPOCH timestamps: https://github.com/rustyhorde/vergen/releases/tag/7.4.2 (commit)

This PR bumps the vergen version thus eliminates the reproducibility issue. 🐻

P.S. One thing to note here is that there is a breaking change in vergen. However, I don't think it affects us.

This commits updates the version of `vergen` which is responsible
for generating the build info. The basis of this change is to support
`SOURCE_DATE_EPOCH` timestamps for reproducible builds.
See <https://reproducible-builds.org/docs/source-date-epoch/>

Signed-off-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
@rapiz1 rapiz1 merged commit 87d06c9 into rapiz1:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants