Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in endpoints parameter for the jupyter.chat method #6052

Merged
merged 13 commits into from
Jul 27, 2020
Merged

adding in endpoints parameter for the jupyter.chat method #6052

merged 13 commits into from
Jul 27, 2020

Conversation

mcminis1
Copy link
Contributor

@mcminis1 mcminis1 commented Jun 23, 2020

Proposed changes:

Status (please check what you already did):

  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@mcminis1
Copy link
Contributor Author

No tests exist (that I can find) for the jupyter notebook methods. So, I don't have any tests to extend. This change is trivial. It seems reasonable to me not to require an additional test.

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

@mcminis1
Copy link
Contributor Author

@rgstephens I've also cleaned up some sphinx warnings for creating docs in the "Continuous Integration / Code Quality (pull_request)" test.

Let me know if you need something else to merge this PR. Thanks you!

@mcminis1
Copy link
Contributor Author

@rgstephens Is this ready to Merge?

@rgstephens rgstephens merged commit b5f6139 into RasaHQ:master Jul 27, 2020
@mcminis1 mcminis1 deleted the 6051_jupyter_chat_action_endpoint branch July 31, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants