-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in i2c-rtc-overlay.dts (and its gpio version) #3642
Comments
I'd be happy to provide a PR for this, but I haven't got a clue how to set things up so it gets into all of the branches... |
Thanks - it will probably be as easy for me to do it all, when I get back to a keyboard. |
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pelwell
added a commit
that referenced
this issue
May 29, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
That's now fixed in all current branches. Thanks again. |
popcornmix
pushed a commit
that referenced
this issue
Jun 3, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 3, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 3, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 3, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 3, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 3, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this issue
Jun 3, 2020
kernel: vc4: Set driver_name for card See: raspberrypi/linux#3656 kernel: configs: Add SND_SOC_MAX98357A=m See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=275919 kernel: Add Micro Crystal RV-1805 to i2c-rtc overlays See: raspberrypi/linux#3651 kernel: media: bcm2835-isp: fix bytes per line calculations for some image formats See: raspberrypi/linux#3645 kernel: media: bcm2835-unicam: change minimum number of vb2_queue buffers to 1 See: raspberrypi/linux#3638 kernel: media: i2c: imx477: Return correct result on sensor id verification See: raspberrypi/linux#3630 kernel: Clean up the VCHIQ 2711 DMA support See: raspberrypi/linux#3629 kernel: overlays: i2c-rtc-gpio: Fix trickle-resistor-ohms param See: raspberrypi/linux#3642 kernel: Enable hwmon for thermal zones See: raspberrypi/linux#3307
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this issue
Jun 3, 2020
kernel: vc4: Set driver_name for card See: raspberrypi/linux#3656 kernel: configs: Add SND_SOC_MAX98357A=m See: https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=275919 kernel: Add Micro Crystal RV-1805 to i2c-rtc overlays See: raspberrypi/linux#3651 kernel: media: bcm2835-isp: fix bytes per line calculations for some image formats See: raspberrypi/linux#3645 kernel: media: bcm2835-unicam: change minimum number of vb2_queue buffers to 1 See: raspberrypi/linux#3638 kernel: media: i2c: imx477: Return correct result on sensor id verification See: raspberrypi/linux#3630 kernel: Clean up the VCHIQ 2711 DMA support See: raspberrypi/linux#3629 kernel: overlays: i2c-rtc-gpio: Fix trickle-resistor-ohms param See: raspberrypi/linux#3642 kernel: Enable hwmon for thermal zones See: raspberrypi/linux#3307
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/linux-mvista
that referenced
this issue
Jun 8, 2020
Source: kernel.org MR: 103889 Type: Enhancement Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y ChangeID: 4d7582eeadaa7d466698eb2c6e9112ce57473ea8 Description: The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/linux-mvista
that referenced
this issue
Jun 8, 2020
Source: kernel.org MR: 103889 Type: Enhancement Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y ChangeID: e4859835ebb2f6300fa22dd7dff4e70a9d6b6630 Description: The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 10, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 10, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 10, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 10, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 17, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 17, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 17, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 17, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this issue
Jun 17, 2020
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: #3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Sep 10, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Sep 10, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Sep 19, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Sep 19, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Sep 23, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Sep 23, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 1, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 1, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 9, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 9, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 15, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 15, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 21, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Oct 21, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Nov 15, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Nov 15, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Nov 17, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Nov 17, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Nov 24, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Nov 24, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 11, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 11, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 21, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 21, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 23, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 23, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 31, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Dec 31, 2021
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Jan 6, 2022
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
it-is-a-robot
pushed a commit
to openeuler-mirror/raspberrypi-kernel
that referenced
this issue
Jan 6, 2022
The abx80x implementation of the trickle-resistor-ohms parameter is missing the ":0" indicating that the target is an integer/cell value. See: raspberrypi/linux#3642 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
linux/arch/arm/boot/dts/overlays/i2c-rtc-overlay.dts
Line 232 in a9cf165
abracon,tc-resistor
needs to have a:0
suffix as the other entries do, otherwise the value provided in config.txt is incorrectly applied to the Device Tree. I've just tested this change locally and adding:0
here resulted in the driver actually using the value I provided (it was ignored otherwise due to an -EOVERFLOW result fromof_property_read_u32
).The text was updated successfully, but these errors were encountered: