dwc_otg: Add ARCH_BCM2835 support #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a duplicate irq range with an offset on the hwirq's so the driver can detect that enable_fiq() is used. Tested with downstream dwc_otg USB controller driver. Signed-off-by: Noralf Trønnes <noralf@tronnes.org> Reviewed-by: Eric Anholt <eric@anholt.net> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
|
No objections. |
| @@ -56,7 +56,7 @@ | |||
| #include "irqchip.h" | |||
|
|
|||
| /* Put the bank and irq (32 bits) into the hwirq */ | |||
| #define MAKE_HWIRQ(b, n) ((b << 5) | (n)) | |||
| #define MAKE_HWIRQ(b, n) (((b) << 5) | (n)) | |||
| #define HWIRQ_BANK(i) (i >> 5) | |||
| #define HWIRQ_BIT(i) BIT(i & 0x1f) | |||
There was a problem hiding this comment.
i should get the same parenthetical treatment as b, no?
|
I just have the one unanswered point (use of parentheses within macros - the commit fixes one by necessity but there are two on adjacent lines that could also be fixed), but otherwise it looks good. |
|
I fixed that one because otherwise I would get a wrong result when I use it later: #define FIQ_START (NR_IRQS_BANK0 + MAKE_HWIRQ(NR_BANKS - 1, 0))The patch is accepted in mainline, so it's too late to change it now. |
pelwell
added a commit
that referenced
this pull request
Jul 24, 2015
dwc_otg: Add ARCH_BCM2835 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on ARCH_BCM2708 and ARCH_BCM2835.