Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Deprecation Warning: cmake_minimum_required #1545

Closed
galmyk opened this issue Nov 13, 2023 · 3 comments
Closed

CMake Deprecation Warning: cmake_minimum_required #1545

galmyk opened this issue Nov 13, 2023 · 3 comments
Milestone

Comments

@galmyk
Copy link
Contributor

galmyk commented Nov 13, 2023

Recently, when building pioasm and/or elf2uf2, CMake warns about cmake_minimum_required:

[ 96%] Performing configure step for 'PioasmBuild'
loading initial cache file /home/gmt/Projects/pico/build/pico-sdk/src/rp2_common/pico_cyw43_driver/pioasm/tmp/PioasmBuild-cache-Release.cmake
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

#1477 reported the problem, but submitted patch is not correct.

@galmyk
Copy link
Contributor Author

galmyk commented Nov 14, 2023

#1546

@peterharperuk
Copy link
Contributor

I can't seem to reproduce this. Do you still have the problem if you delete your build folder and start from scratch?

@kilograham kilograham added this to the 1.5.2 milestone Dec 15, 2023
@kilograham
Copy link
Contributor

merged into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants