Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix cmake deprecation warnings #1477

Merged

Conversation

stefanb2
Copy link
Contributor

When running a project build against Pico C/C++ SDK on a Fedora 38 development machine with

$ cmake --version
cmake version 3.27.2

you get deprecation warnings for the tools sub-directory

...
[13/108] Performing configure step for 'PioasmBuild'
loading initial cache file /[REDACTED]/build/pico-sdk/src/rp2_common/pico_cyw43_driver/pioasm/tmp/PioasmBuild-cache-Release.cmake
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
...

Raising the minimum CMake version to the same version as is already required in the top-level CMakeLists.txt removes the build warning.

Running a build with a newer CMake version results in a deprecation
warning from the tools subdirectory

    [13/108] Performing configure step for 'PioasmBuild'
    loading initial cache file /.../build/pico-sdk/src/rp2_common/pico_cyw43_driver/pioasm/tmp/PioasmBuild-cache-Release.cmake
    CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
      Compatibility with CMake < 3.5 will be removed from a future version of
      CMake.

      Update the VERSION argument <min> value or use a ...<max> suffix to tell
      CMake that the project does not need compatibility with older versions.

Raise the minimum version requirement for the tools to the same version
that is required in the top-level CMakeLists.txt anyway.
@stefanb2 stefanb2 changed the base branch from master to develop August 17, 2023 08:23
@stefanb2 stefanb2 changed the title tools: fix cmake warnings tools: fix cmake deprecation warnings Aug 17, 2023
@kilograham kilograham added this to the 1.5.2 milestone Aug 17, 2023
@kilograham kilograham merged commit f85d679 into raspberrypi:develop Aug 17, 2023
1 check passed
@stefanb2 stefanb2 deleted the topic-tools-fix-cmake-warnings branch August 17, 2023 17:58
@kilograham kilograham modified the milestones: 1.5.2, 1.6.0 Dec 14, 2023
mungewell pushed a commit to mungewell/pico-sdk that referenced this pull request Mar 18, 2024
Running a build with a newer CMake version results in a deprecation
warning from the tools subdirectory

    [13/108] Performing configure step for 'PioasmBuild'
    loading initial cache file /.../build/pico-sdk/src/rp2_common/pico_cyw43_driver/pioasm/tmp/PioasmBuild-cache-Release.cmake
    CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
      Compatibility with CMake < 3.5 will be removed from a future version of
      CMake.

      Update the VERSION argument <min> value or use a ...<max> suffix to tell
      CMake that the project does not need compatibility with older versions.

Raise the minimum version requirement for the tools to the same version
that is required in the top-level CMakeLists.txt anyway.
aswild pushed a commit to aswild/pico-sdk that referenced this pull request May 3, 2024
Running a build with a newer CMake version results in a deprecation
warning from the tools subdirectory

    [13/108] Performing configure step for 'PioasmBuild'
    loading initial cache file /.../build/pico-sdk/src/rp2_common/pico_cyw43_driver/pioasm/tmp/PioasmBuild-cache-Release.cmake
    CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
      Compatibility with CMake < 3.5 will be removed from a future version of
      CMake.

      Update the VERSION argument <min> value or use a ...<max> suffix to tell
      CMake that the project does not need compatibility with older versions.

Raise the minimum version requirement for the tools to the same version
that is required in the top-level CMakeLists.txt anyway.

Cherry-Pick: f85d679
@kilograham kilograham modified the milestones: 1.6.0, 1.5.2 May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants