Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-lightning on the RaspiBlitz #2295

Closed
openoms opened this issue May 11, 2021 · 28 comments
Closed

C-lightning on the RaspiBlitz #2295

openoms opened this issue May 11, 2021 · 28 comments
Milestone

Comments

@openoms
Copy link
Collaborator

openoms commented May 11, 2021

Will share the development of the c-lightning implementation here.

The first functional install script is in:
https://github.com/openoms/raspiblitz/blob/cblitz/home.admin/config.scripts/cln.install.sh

The aim is to have c-lightning first as an optional service and later as a full featured alternative of LND.

The development is helped by being able to run signet and testnet parallel as in: #2290

@rootzoll rootzoll added this to the 1.8 Release milestone May 18, 2021
@openoms
Copy link
Collaborator Author

openoms commented May 23, 2021

Many new things are functional now:

  • CLN menu for basic lightning actions like
  • FUNDING
  • PEERING
  • CHANNEL
  • PAY
  • REQUEST
  • Sparko plugin - providing a web interface and connection to Zeus / Spark Wallet
  • C-Lightning-REST for RTL
  • further improvements of running the chains and LND/CLN services parallel

Working in the branch https://github.com/openoms/raspiblitz/tree/cblitz which can be synchronised for testing from UPDATE.
Don't use mainnet funds yet please.

@openoms
Copy link
Collaborator Author

openoms commented Jun 1, 2021

The status screen and parallel networks are functional.
image

If syncing from
https://github.com/openoms/raspiblitz/tree/cblitz
or
https://github.com/rootzoll/raspiblitz/tree/pre-1.7.1
make the new scripts executable with:
chmod +x *.sh
and a restart is necessary.

For C-lightning the keys will be generated from 24 words which will be created by the BIP39 reference implementation: https://github.com/trezor/python-mnemonic#python-mnemonic. This way the on-chain wallet backup will be similar to LND and other wallets.

Automating the seed creation, encryption, decryption and auto-unlock is depending on the solution of ElementsProject/lightning#4570.

@openoms
Copy link
Collaborator Author

openoms commented Jun 2, 2021

Next up:

Note on recovery: Most funds in channels (with the feature: option_static_remotekey) can be recovered after the peer force closes the channel unilaterraly: https://lightning.readthedocs.io/FAQ.html?highlight=option_static_remotekey#database-corruption-channel-state-lost

@rootzoll rootzoll modified the milestones: 1.8 Release, 1.7.1 Release Jun 14, 2021
openoms added a commit to openoms/raspiblitz that referenced this issue Jun 23, 2021
similar to the nginx model make 2 directories for plugins:
cln-plugins-enabled - symlinked to ~/.lightning/plugins
plugins from here are loaded automatically on cln start

cln-plugins-available: plugins are downloaded here to
be run until the next cln restart (or stopped with runonce)

note the disk is mounted with noexec so plugins can't
run from there

discuss in: raspiblitz#2295
openoms added a commit to openoms/raspiblitz that referenced this issue Jun 25, 2021
openoms added a commit to openoms/raspiblitz that referenced this issue Jun 25, 2021
openoms added a commit to openoms/raspiblitz that referenced this issue Jun 25, 2021
Usage options:
cln-plugin.backup.sh [on] [testnet|mainnet|signet]
cln-plugin.backup.sh [restore] [testnet|mainnet|signet] [force]
cln-plugin.backup.sh [backup-compact] [testnet|mainnet|signet]
https://github.com/lightningd/plugins/tree/master/backup

Discussed in: raspiblitz#2295
openoms added a commit to openoms/raspiblitz that referenced this issue Jun 25, 2021
Install and show the output of the chosen plugin for C-lightning
Usage:
cln-plugin.standard-python.sh on [plugin-name] [testnet|mainnet|signet] [runonce]
tested plugins:
summary | helpme | feeadjuster

find more at:
https://github.com/lightningd/plugins
discussed in:
raspiblitz#2295
@openoms
Copy link
Collaborator Author

openoms commented Jun 28, 2021

The latest state is in: https://github.com/rootzoll/raspiblitz/tree/pre-1.7.1

  • A round of testing is due after some heavy refactoring.

Outstanding:

openoms added a commit to openoms/raspiblitz that referenced this issue Jun 29, 2021
encrypt | decrypt | autounlock the hsm_secret for C-lightning
usage:
cln.hsmtool.sh [unlock] [testnet|mainnet|signet]
cln.hsmtool.sh [encrypt|decrypt] [testnet|mainnet|signet]
cln.hsmtool.sh [autounlock-on|autounlock-off] [testnet|mainnet|signet]

discussed in: raspiblitz#2295
openoms added a commit to openoms/raspiblitz that referenced this issue Jun 29, 2021
script to set up or update the CLN systemd service
checks for hsm_secret encryption, autounlock and the sparko plugin
usage:
/home/admin/config.scripts/cln.install-service.sh $CHAIN

discussed in: raspiblitz#2295
openoms added a commit that referenced this issue Jul 20, 2021
changed the config paths to $lightning-dir/config or /networkname/config

plugins are downloaded to the SDcard:
/home/bitcoin/cln-plugins-available/
symlinked and loaded automatically from:
/home/bitcoin/${netprefix}cln-plugins-enabled

Related: #2295
rootzoll added a commit that referenced this issue Aug 3, 2021
* fix copychain returns

* typo in sync loop

* stop services on inconsistent state

* calling correct provisioning

* apply bitcoin and lncli aliases in all scripts

* network.aliases: add CLNETWORK

* make cln default plugin dir: cln-plugins-enabled

similar to the nginx model make 2 directories for plugins:
cln-plugins-enabled - symlinked to ~/.lightning/plugins
plugins from here are loaded automatically on cln start

cln-plugins-available: plugins are downloaded here to
be run until the next cln restart (or stopped with runonce)

note the disk is mounted with noexec so plugins can't
run from there

discuss in: #2295

* move shutdown script

* change all place where shutdown script is used

* change notify & release

* moved shutdown script

* moved shutdown scripts

* add more debug info

* moving github script

* remove chain in sync

* no longer needed chain in sync

* move debug script

* patch patch command

* make sure setup file is sourced

* remove debug output

* make sure lnd is put behind tor

* change indent

* get fresh sync progress

* avoid scrolling in menus

* use new selfsignedcert if no lnd tls.cert present

* sparko: add info and connect menu with own cert

#2295

* cln.rest: add connect option for Zeus

#2295

* cln: add the backup plugin + options

Usage options:
cln-plugin.backup.sh [on] [testnet|mainnet|signet]
cln-plugin.backup.sh [restore] [testnet|mainnet|signet] [force]
cln-plugin.backup.sh [backup-compact] [testnet|mainnet|signet]
https://github.com/lightningd/plugins/tree/master/backup

Discussed in: #2295

* cln: add cln-plugin.standard.python.sh

Install and show the output of the chosen plugin for C-lightning
Usage:
cln-plugin.standard-python.sh on [plugin-name] [testnet|mainnet|signet] [runonce]
tested plugins:
summary | helpme | feeadjuster

find more at:
https://github.com/lightningd/plugins
discussed in:
#2295

* shellcheck: change all `egrep` to `grep -E`

https://github.com/koalaman/shellcheck/wiki/SC2196

* do not resolve aliases, use as variables

* lnd: fix lnd.conf for parallel networks

discussed in: #2290

* lnd: add LND option for parallel networks

* deprecate Testnet in SETTINGS
keysend and autopilot only for mainnet

due to: #2290

* lnd: autopilot and autounlock for testnet

* fix comments

* add the SYSTEM menu for parallel chains

* RTL update to v0.11.0

make chain specific directory for the config: /home/rtl/${netprefix}RTL/
use ${netprefix}lnd.conf in config
override Environmen tvaribales for cln in the systemd service:
/etc/systemd/system/${netprefix}${typeprefix}RTL.service

discussed in: #2384

* lnd.setname.sh for testnet

* display ${CHAIN} in the SYSTEM menu options

* keep _aliases file when live patches are applied

* all lncli_aliases to be used as variables

* default to KIllMode=control-group in services

https://www.man7.org/linux/man-pages/man5/systemd.kill.5.html
discussed in: #1901

* add cln.hsmtool.sh for  hsm_secret handling

encrypt | decrypt | autounlock the hsm_secret for C-lightning
usage:
cln.hsmtool.sh [unlock] [testnet|mainnet|signet]
cln.hsmtool.sh [encrypt|decrypt] [testnet|mainnet|signet]
cln.hsmtool.sh [autounlock-on|autounlock-off] [testnet|mainnet|signet]

discussed in: #2295

* add cln.install-service.sh to set up cln with systemd

script to set up or update the CLN systemd service
checks for hsm_secret encryption, autounlock and the sparko plugin
usage:
/home/admin/config.scripts/cln.install-service.sh $CHAIN

discussed in: #2295

* use symlink to cln-plugins-enabled for all plugins

* keep lnd autopilot and autounlock mainnet only

mainnet only settings:
lnd autopilot
lnd keysend
circuibreaker
lnd autounlock
StaticChannelBackup to DropBox and USB

* cln FUNDING fix parsing address

* cln.hsmtool: add change-password and lock options

* always set password A

* cached peer info

* fix printing cache

* fix check for existing files

* handle bitcoind not running

* result with newline

* test line break

* test new line

* test new line

* two vars on output

* #2388 improve online check (less pinging)

* used cached peer status

* move chache

* cach file permissions

* allow sudo call

* fix cache

* remove double scan info

* add conf info to sync screen

* reorder info

* add space

* add space

* order info

* internet suppress error messages

* order info

* fix offering Blockchain copy

* fix hostname

* final ready state info

* lnd unlock after provision

* remove debug exit

* harmonize ready state

* add status to lnd unlock

* update lnd unlock script

* edit the unlock

* remove debug echo

* add debug

* add debug

* fix if statement

* debug output

* switch position of source setupdata

* #1126 preparing new setup with new c-lightning  (#2396)

* move debug script

* patch patch command

* make sure setup file is sourced

* remove debug output

* make sure lnd is put behind tor

* change indent

* get fresh sync progress

* always set password A

* cached peer info

* fix printing cache

* fix check for existing files

* handle bitcoind not running

* result with newline

* test line break

* test new line

* test new line

* two vars on output

* #2388 improve online check (less pinging)

* used cached peer status

* move chache

* cach file permissions

* allow sudo call

* fix cache

* remove double scan info

* add conf info to sync screen

* reorder info

* add space

* add space

* order info

* internet suppress error messages

* order info

* fix offering Blockchain copy

* fix hostname

* final ready state info

* lnd unlock after provision

* remove debug exit

* harmonize ready state

* add status to lnd unlock

* update lnd unlock script

* edit the unlock

* remove debug echo

* add debug

* add debug

* fix if statement

* debug output

* switch position of source setupdata

* lnd.unlock: fix typo

* netwok.monitor.sh debug

* cln-plugin.summary: fix paths

* rtl: fix permission of config on copy

* CASHOUT: use aliases for lnd

* rtl: install correctly for paralell chains

* use CHAIN in CLN and LND menu

* cln: add  CASHOUT option

* CLOSEALL and  CASHOUT: Improve labels and comments

Explaining CASHOUT in the label as discussed in:
#2358

* cln.install: fix tor config

* cln: installthe  latest master until the next release

* _commands: source _aliases only if exists

* network aliases: fall back to 'main' for 'chain'

* new setup: keep testnet3 blocks and chainstate

* new setup: improve capitalization in menu

* improve help and comments

* cln: install Sparko if configured, but not present

* cln: add new wallet and import seed options

* fix peernum

* make sure that aliases get created on lnd setup

* no error if aliases not yet exist

* debug state

* fix network alias when not set

* fix syntax error

* add debug error info

* mute unlocking echos

* add debug wait

* add debug wait

* make sure info is uptodate

* make alias info as defaults

* rename option

* update sync info for no lightning

* add action string

* update sync info

* move name dialog

* wait for sync progress info

* wait for syncprogress info

* fix syntax

* get fresh data

* make sure to disable lnd

* add c-lightning to debug

* add setup logs to debug output

* fix syntax error

* add new-force wallet

* try fix call hsmtool

* hsm output tool

* fix output

* add seed-force

* refactor blitz.mnemonic.py

* test seed

* debug info

* dump object

* try check

* correct putput

* fix syntax

* check lnd for valid seed

* fix gui

* add Suez install script

discussed in:
#2366

* cln rescue file export

* get correct version

* add cln export gui

* cln.backup.sh cln-import

* correct bytesize

* generate cln wallet with passwordc

* fix syntax

* fix syntax

* mute not needed error msg

* PEERING: correct message on success

* cln.install-service: fix sparko check

* add Suez to menu for CLN and LND

needs to be installed with the bitcoin user to be able to interact with CLN
related: #2366

* debug _provison.setup.sh

stop bitcoind and restart with new config to avoid rpc password error
disable and enable service instead of daemon-reload
CLN: don't use passwordC  as seedPassword

* add cln.setname.sh

make lnd.setname.sh work with parallel wallets

* improve comments

* SYSTEM: add CLNLOG and CLNCONF options

* SYSTEM menu fixes

* cln: add more aliases cln, clnlog, clnconf

* cln: activate the backup plugin on every install

* SERVICES menu: fix chantools/CLN switch

* cln: load plugins from ${netprefix}cln-plugins-enabled

changed the config paths to $lightning-dir/config or /networkname/config

plugins are downloaded to the SDcard:
/home/bitcoin/cln-plugins-available/
symlinked and loaded automatically from:
/home/bitcoin/${netprefix}cln-plugins-enabled

Related: #2295

* sparko: don't show logs after install

* #2425 Adding experimental Blitz WebUI & API (#2426)

* no password C & D when cln

* add debug echos

* set defaults before

* #2228 wider grep to detect nvms (#2427)

* cln.hsmtool: init backup with the new wallet

* cln.install: fix access to raspiblitz.conf

* cln-plugin.backup: fix path to backup-cli

* cln: hide unhelpful warnings during setup

* remove old jinja template rendering

* fix lnd unlock detection

* cln: look for files in .lightning dir with sudo

* cln: correct lightning name in FInalDialog + typo

* cln: make sure .lightning/bitcoin dir exists

* FinalDialog: make the 24 words fit

* cln.install.sh: create cln config if not present

* Simplify localIP detection and improve compatibility (#2432)

* show tail info on provision

* only show lnd options when activated

* fix syntax

* only show main lightning impl options for RC1

* cln: always start the lightnind.service

* cln: clear before showing summary

* start cln on the end of provisioning

* exit 0 on cln menu

* press key after single actions

* remove key press on cln actions

* change to none

* detect cln running

* fix syntax

* fix lightniing info

* add TODO for CLN

* add clnblockheight

* zty with user bitcoin

* check synced to chain for cln

* fix increment

* try scanprogress

* use cln sync detection and progress

* replace LNTYPE

* next line

* fix spaces

* fix spaces

* Update README.md (#2456)

Fix 404

* Fix FAQ links (#2441)

* Fix invalid URL ( (#2440)

* support channels (#2382)

* use #2370 height optimization

* adjust exit codes in menu scripts

* adjust password menu exit codes

* adapt shutdown for cln

* settings adapt to running lightning impl

* fix syntax

* debug info

* add debug

* better height

* add default values

* add config entry if not there yet

* change default value

* Added exit info for cln

* make sure to load config file if available

* add sparko to menu

* add default for sparko

* replace default sparko entry

* show sparko installed or not

* add more description to sparko option

* RTL for clightnign in service menu

* main menu item rtl

* add RTL description

* debug in RTL install

* install sparko on recovery

* update menu with cln

* rework menu options

Co-authored-by: openoms <oms@tuta.io>
Co-authored-by: openoms <43343391+openoms@users.noreply.github.com>
Co-authored-by: rek79 <rek79@users.noreply.github.com>
Co-authored-by: Bitpaint <67663265+bitpaint@users.noreply.github.com>
Co-authored-by: João Thallis <joaothallis@icloud.com>
Co-authored-by: Peter Flock <78184669+peterflock@users.noreply.github.com>
Co-authored-by: nyxnor <nyxnor@protonmail.com>
@openoms
Copy link
Collaborator Author

openoms commented Aug 10, 2021

52d71f7 adds the CLBOSS plugin - The C-Lightning Node Manager
CLBOSS is an automated manager for C-Lightning forwarding nodes.
more info: ttps://github.com/ZmnSCPxj/clboss#operating

install with:
config.scripts/cln-plugin.clboss.sh on

The CLBOSS data is stored in the .lightning dir with all the other node speficic files:
image

@openoms
Copy link
Collaborator Author

openoms commented Aug 10, 2021

Screenshots from Zeus v0.5.2:

C-lightningREST connection screen:
IMG_20210810_203251

Spark connection screen (no option to scan a QR):
IMG_20210810_203306

Managed to connect through both using LAN and Tor, but pasting the strings was manual after scanning them, one by one.

@rootzoll
Copy link
Collaborator

@openoms do you think a QR code connection with Zeus for c-lightning is possible within the next 2 weeks or should we target for the v1.7.1 release a workaround - like a short text describing the user how to connect manually?

@openoms
Copy link
Collaborator Author

openoms commented Aug 16, 2021

@rootzoll I think the best we can do is to coordinate with the Zeus team in ZeusLN/zeus#515 to ask them to implement a QRcode parsing the way it will be implemented in the RaspiBlitz.

Spark-wallet already does use a QRcode format, but it needs a CA signed certificate (or importing the certificate in the phone which is far from easily atm).
Should try if it can be used with LetsEncrypt HTTPS Domain subscription.

@rootzoll
Copy link
Collaborator

rootzoll commented Aug 17, 2021

@openoms On a test build of the modified sd build script with c-lightning I ran into this that made the build stop:

  inflating: clightning-v0.10.1/wire/wire_sync.h
- Configuring EXPERIMENTAL_FEATURES enabled
Compiling ccan/tools/configurator/configurator.../usr/bin/ld: cannot open output file ccan/tools/configurator/configurator: Permission denied
collect2: error: ld returned 1 exit status
- Building from source C-lightning
File config.vars not found: you must run ./configure before running make.
make: *** No rule to make target 'config.vars', needed by 'show-flags'.  Stop.
- Install to /usr/local/bin/
File config.vars not found: you must run ./configure before running make.
mkdir -p /bin
mkdir -p /libexec/c-lightning
mkdir -p /libexec/c-lightning/plugins
mkdir -p /share/man/man1
mkdir -p /share/man/man5
mkdir -p /share/man/man7
mkdir -p /share/man/man8
mkdir -p /share/doc/c-lightning
make: *** No rule to make target 'config.vars', needed by 'ccan/config.h'.  Stop.

This seems where the problem is:

pi@raspberrypi:/home/admin/download/cln/clightning-v0.10.1 $ sudo -u admin ./configure --enable-experimental-features
Compiling ccan/tools/configurator/configurator.../usr/bin/ld: cannot open output file ccan/tools/configurator/configurator: Permission denied
collect2: error: ld returned 1 exit status

@rootzoll
Copy link
Collaborator

It runs when using just sudo @openoms is there a specific reason why building it with sudo -u admin

@openoms
Copy link
Collaborator Author

openoms commented Aug 17, 2021

@rootzoll wanted to avoid to run the compilation with root, but does not make much difference really.
I have tested the script from the admin user, not pi, which could be the difference.

fixed in 656be6d (tested by running with sudo from the user pi)

@openoms
Copy link
Collaborator Author

openoms commented Aug 18, 2021

@openoms do you think a QR code connection with Zeus for c-lightning is possible within the next 2 weeks or should we target for the v1.7.1 release a workaround - like a short text describing the user how to connect manually?

I think since the QR format is still in flux we should show the access-key or macaroon in itself in a QR and put the explanation to paste bit manually to Zeus.

Can have two steps switching the QRcode on the LCD after enter:
first would just show the access-key or macaroon
second the onion address

so they can be scanned individually and pasted in the app manually.

@rootzoll
Copy link
Collaborator

@openoms sounds good as an temp workaround. Will you work on that?

@openoms
Copy link
Collaborator Author

openoms commented Aug 19, 2021

@openoms sounds good as an temp workaround. Will you work on that?

sure will sort it

openoms added a commit that referenced this issue Aug 24, 2021
Showing the Tor address and Acces Key / Macaroon individually
to be scanned and pasted into the wallets
Discussed in: ZeusLN/zeus#515
and #2295
@rootzoll rootzoll added the final testing was fixed - needs testing label Aug 24, 2021
@rootzoll
Copy link
Collaborator

This will be contained in v1.7.1rc1 for further intense testing.

@openoms
Copy link
Collaborator Author

openoms commented Aug 31, 2021

Added a CLNREPAIR menu to cover the functions of cln.hsmtool.sh in the dialogs
image
image

The hsm_secret password is equivalent to the Password_C for LND.
By default the hsm_secret is stored in cleartext on the disk.
If encrypted the hsm_secret password is kept in memory between restarts.
The AUTOUNLOCK means that the hsm_secret password is stored on the disk in cleartext.

Creating a new C-ligtning wallet will now create a seedwords.info beneath the hsm_secret with the contents:

# This file was placed by cln.hsmtool.sh .
# Contains the seed words from which the hsm_secret in the same directory was generated
seedwords='${seedwords}'
seedwords6x4='${seedwords6x4}'
# Will be removed safely when the hsm_secret is encrypted.
# This file is placed by cln.hsmtool.sh .
# The seed words from which the hsm_secret in the same directory was generated
# were deleted when the hsm_secret was encrypted.
# The words cannot be generated from the hsm_secret (one way function).
# If you don't have the words the hsm_secret can be still backed up in hex:
# https://lightning.readthedocs.io/BACKUP.html#hsm-secret 

@openoms
Copy link
Collaborator Author

openoms commented Aug 31, 2021

Some simpler tasks to do next:

  • CLBOSS - Automatic channel management for C-lightning

  • SPARK - Spark Wallet to manage the C-Lightning wallet (possible replacement for Sparko)

  • Update https://github.com/Ride-The-Lightning/c-lightning-REST/releases/

  • Add a custom binary as a C-ligthning plugin - this likely will be a manual guide to start with due to the lack of standards as now

  • List closed channels with details - waiting for a plugin do this other wise if is a potentially harmful direct (external) sqllite query

@rootzoll
Copy link
Collaborator

rootzoll commented Sep 9, 2021

OK added "display-seed" option to cln.install.shthat now will be called if user activated the secondary/parallel cln wallet.

@openoms
Copy link
Collaborator Author

openoms commented Sep 20, 2021

Future integrations will be recorded for the v1.8 milestone

@rootzoll
Copy link
Collaborator

@openoms for the CLN LNbits best would be to open a ticket on v1.8.0 milestone.

@openoms
Copy link
Collaborator Author

openoms commented Oct 11, 2021

Final tests:

  • CL BACKUP
  • CL SEEDRESTORE
  • CL FILERESTORE

@rootzoll
Copy link
Collaborator

I switched an LND node to CL default and the deactivated runBehindTor .. CL seems not to start up in that configuration:

*** C-LIGHTNING (MAINNET) SYSTEMD STATUS ***
● lightningd.service - c-lightning daemon on mainnet
   Loaded: loaded (/etc/systemd/system/lightningd.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Mon 2021-10-11 15:53:30 BST; 3s ago
  Process: 25871 ExecStartPre=/home/admin/config.scripts/cl.check.sh prestart mainnet (code=exited, status=0/SUCCESS)
  Process: 25880 ExecStart=/bin/sh -c /usr/local/bin/lightningd --conf=/home/bitcoin/.lightning/config  (code=exited, status=1/FAILURE)
 Main PID: 25880 (code=exited, status=1/FAILURE)

*** LAST 30 C-LIGHTNING (MAINNET) INFO LOGS ***
sudo tail -n 30 /mnt/hdd/lnd/logs/bitcoin/mainnet/lnd.log
2021-10-11T14:52:24.958Z UNUSUAL plugin-backup.py:   File \"/home/bitcoin/cl-plugins-enabled/backup.py\", line 135, in <module>
2021-10-11T14:52:24.958Z UNUSUAL plugin-backup.py:     kill(\"Could not find backup.lock in the lightning-dir\")
2021-10-11T14:52:24.959Z UNUSUAL plugin-backup.py:   File \"/home/bitcoin/cl-plugins-enabled/backup.py\", line 110, in kill
2021-10-11T14:52:24.959Z UNUSUAL plugin-backup.py:     procs = [p for p in psutil.Process(os.getpid()).parents()]
2021-10-11T14:52:24.959Z UNUSUAL plugin-backup.py: AttributeError: 'Process' object has no attribute 'parents'
2021-10-11T14:52:25.006Z INFO    plugin-backup.py: Killing plugin: exited before replying to getmanifest

@rootzoll
Copy link
Collaborator

@openoms the problem seems to be

2021-10-11T14:56:10.765Z INFO    plugin-backup.py: Could not find backup.lock in the lightning-dir

@openoms
Copy link
Collaborator Author

openoms commented Oct 11, 2021

will,need to run:
config.scripts/cl-plugin.backup.sh init
if that lock file is not present I think. Will have a look.

@openoms
Copy link
Collaborator Author

openoms commented Oct 11, 2021

@rootzoll to be clear I did not test C-lightning without Tor so this combination will not work with v1.7.1.

Otherwise all the SWITCHLN option does is changes to ligthning=cl in the raspiblitz.conf so the menus and scripts can accommodate.

@rootzoll
Copy link
Collaborator

We need to refactor the clearnet mode for v1.8.0 anyway. So its OK for now.
@openoms let me know when you have the cl-plugin.backup.sh init fix ready .. then I think the issue is ready to close for v1.7.1 release.

@openoms
Copy link
Collaborator Author

openoms commented Oct 11, 2021

The backup plugin is already always reinitialized when cl-plugin.backup.sh on is run
During:

Could not reproduce the issue just by switching to the CL node to be default.

@rootzoll
Copy link
Collaborator

OK .. so lets render this as an edge case for now and see what reports come in on this after final release. If there is something we didnt see we can always do a quick 1.7.2 before 1.8.0 - closing this issue.

@rootzoll rootzoll removed the final testing was fixed - needs testing label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants