Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B1.0 pre5 #63

Merged
merged 25 commits into from
Mar 3, 2020
Merged

B1.0 pre5 #63

merged 25 commits into from
Mar 3, 2020

Conversation

Athanaseus
Copy link
Member

Should fix #61

@Athanaseus Athanaseus requested a review from o-smirnov February 28, 2020 15:15
@o-smirnov
Copy link
Contributor

@Athanaseus: looking at this build https://travis-ci.org/ratt-ru/radiopadre/jobs/656319201?utm_source=github_status

...it's still trying to build a wheel and failing with jupyter not found.

@Athanaseus
Copy link
Member Author

@Athanaseus: looking at this build https://travis-ci.org/ratt-ru/radiopadre/jobs/656319201?utm_source=github_status

...it's still trying to build a wheel and failing with jupyter not found.

I'll look into this in-depth, I'm suspecting that the customized setup.py has to do with this.

@o-smirnov o-smirnov mentioned this pull request Feb 28, 2020
@Athanaseus
Copy link
Member Author

Approved.

@o-smirnov should I proceed and remove the wheel distribution? I figured out a way to build then successfully or get rid of them completely.

Only deploy source dist
Remove `jupyter` as a build dep
@o-smirnov
Copy link
Contributor

OK cool, so as discussed let's just disable the wheels (travis is currently failing on that), and push the pre5 release.

@Athanaseus
Copy link
Member Author

This is ready for shipping. No wheels firing.

A custom class is now defined. It throws only a warning instead of an error that no (.whl) files are produced.

@o-smirnov is this issue (kernsuite/packaging#176) still barrier?
i.e. astropy #<2.0.11
Might relate to numpy/numpy#11871 (Or numpy version)

Also this jupyter/notebook#4303 seems like it's resolved.
i.e. notebook #<5.7.3

@o-smirnov
Copy link
Contributor

All those issues seem to have resolved (which is why the hard version requirement has been commented out). I'm going to push the release button on this.

@o-smirnov o-smirnov merged commit 6f2d989 into master Mar 3, 2020
@o-smirnov
Copy link
Contributor

@Athanaseus now that it's merged, I'm getting a travis failure but a weird one, "PyPI upload failed."

@o-smirnov
Copy link
Contributor

See here: https://travis-ci.org/ratt-ru/radiopadre/jobs/657656565

Any idea what's going on?

@adrianjhpc
Copy link
Collaborator

Might need an upgrade of setuptools?

@Athanaseus
Copy link
Member Author

Ah I added the README as part of the package long description so that it gets rendered on PYPI. My bad the error above is due to PYPI not supporting .md instead, it requires .rst. Should I remove that part for now or maybe invest some time in porting it? reStructuredText is also good for writing complex documents that auto-generating doc tools like Sphinx can interpret. But maybe this can come later with the next tractor implementing readthedocs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this wheel's on fire
3 participants