Improve Docker Project Control Code #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the standardised project_run_isolated() shell function and removes previously used analogous driver functions. Introduces the standardised PROJECT_CONTAINER_* shell variables to control some aspects about project containers. Introduces the PROJECT_CONTAINER_IMAGE_BUILD env var to allow users to skip the Docker image building. Adds the --interactive argument to the docker run command to allow for interactive usage with dev containers from the command line.
kilo52
added
Improvement
This was
linked to
issues
May 23, 2024
Fixed variable typos. Fixed wrong return code propagation for docker build commands. Improved Python templates related to Docker interactive testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the standardised
project_run_isolated()shell function.Removes previously used analogous shell driver functions used by build and test scripts.
Introduces the standardised
PROJECT_CONTAINER_*shell variables to control some aspects about project containers.Introduces the
PROJECT_CONTAINER_IMAGE_BUILDenvironment variable to allow users to skip the Docker image building.Adds the
--interactiveargument to thedocker runcommand to allow for interactive usage with dev containers from the command line.