Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add begining of docs for editor #144

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add begining of docs for editor #144

wants to merge 7 commits into from

Conversation

Milerius
Copy link
Member

No description provided.

The albinos configuration editor works in a complementary way with `albinos daemon service`.

The albinos editor binary comes with a dynamic library containing albinos API functionality,
This way when a client enters a command the function is directly called from the `DLL`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I4d object to the use of DLL since that may be confusing as it is primarly used for windows.

Copy link
Member

@Gaspard-- Gaspard-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a .idea directory?

Copy link
Member

@Gaspard-- Gaspard-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mergeable in the current state, nevertheless here are a few comments

Below is the list of prerequisites to compile albinos-editor on your machine:

* Nim version 0.18 minimum
* Nimble
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add instructions on how to get this. Isn't as straightforward as you make it out to be.
This is mostly because as far I know most package managers don't provide nimble.
A simple link to the official download or something like that would suffice.


## Getting Started

These instructions will get you a copy of the project up and running on your local machine for development and testing purposes. See deployment for notes on how to deploy the project on a live system.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is "deployment"?

@Milerius
Copy link
Member Author

I Will still update this pull request, please dont merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants