RavenDB-13921 upgraded Jint #9614
Conversation
| public Dictionary<string, BlittableObjectProperty> OwnValues = | ||
| new Dictionary<string, BlittableObjectProperty>(); | ||
| public HashSet<Key> Deletes; | ||
| public Dictionary<Key, BlittableObjectProperty> OwnValues = new Dictionary<Key, BlittableObjectProperty>(); |
There was a problem hiding this comment.
As you anyway have custom build of Jint, there's also possibility to make StringDictionarySlim public and use it. It's basically the tuned version of Dictionary (some history here).
There was a problem hiding this comment.
Or maybe it is better to include 'Microsoft.Experimental.Collections' and use DictionarySlim<TK, TV> instead of Jint's string version. What are benefits of StringDictionarySlim<T> vs DictionarySlim<string, T> or DictionarySlim<Jint.Key, T> ?
Last one seems like the most reasonable option, because we would have an opportunity to take leverage from Key. Thoughts?
There was a problem hiding this comment.
Probably the most convenient path is to use the MS Experimental. Jint version just skips GetHashCode etc and accesses the struct field directly.
No description provided.