Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(universal-alert): support bytedance #73

Merged
merged 5 commits into from
Apr 21, 2020
Merged

Conversation

wanglijie
Copy link
Contributor

No description provided.

@wanglijie wanglijie changed the title Tt alert feat(universal-alert): support bytedance Apr 10, 2020

const alert = (options: Options): Promise<null> => {
return new Promise((resolve, reject): void => {
const { title = '', content = '', buttonText = '确定' } = options;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基础 api 默认值是否可以考虑英文

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其它端目前都是中文默认,如果要改可能会 break

@ChrisCindy ChrisCindy self-requested a review April 21, 2020 03:14
@SoloJiang SoloJiang merged commit 89af5fd into raxjs:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants