Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit all exposed fields in helm charts #549

Closed
2 tasks done
kevin85421 opened this issue Sep 9, 2022 · 2 comments · Fixed by #839
Closed
2 tasks done

Revisit all exposed fields in helm charts #549

kevin85421 opened this issue Sep 9, 2022 · 2 comments · Fixed by #839
Assignees
@kevin85421
Labels
enhancement New feature or request P1 Issue that should be fixed within a few weeks
Milestone
v0.5.0 release

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

We need to revisit all exposed fields in helm charts to determine which one should be an optional argument for users. We need to explicitly set the default values for the optional fields. As mentioned in #548 #537, undefined arguments will cause some errors in old helm versions.

Use case

See related issues.

Related issues

#537
#544

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added the enhancement New feature or request label Sep 9, 2022
@kevin85421
Copy link
Member Author

cc @DmitriGekhtman

@kevin85421 kevin85421 self-assigned this Sep 9, 2022
@DmitriGekhtman
Copy link
Collaborator

Making configuration as simple and accessible as possible is important! Hence, P1 (moderate priority).

@DmitriGekhtman DmitriGekhtman added the P1 Issue that should be fixed within a few weeks label Sep 14, 2022
@kevin85421 kevin85421 added this to the v0.5.0 release milestone Dec 13, 2022
@kevin85421 kevin85421 mentioned this issue Dec 13, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin85421 kevin85421

Labels
enhancement New feature or request P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
v0.5.0 release
Development

Successfully merging a pull request may close this issue.

Remove unused fields from KubeRay operator and RayCluster charts kevin85421/kuberay
2 participants
@kevin85421 @DmitriGekhtman