[Bug] Helm chart install fails due to undefined worker key in values.yml #537
Labels
bug
Something isn't working
Comments
|
Someone else posted an issue about the same thing, but somehow I can't find it. Also, I'm not able to reproduce this against master. It should be possible by running cc @kevin85421 |
|
Not the behaviour I see on my end: |
tbabej
added a commit
to ProteinQure/kuberay
that referenced
this issue
Sep 7, 2022
This allows comparison between boolean types, i.e. see
ray-cluster/templates/raycluster-cluster.yaml:107, where we assert:
{{- if ne .Values.worker.disabled true }}
The default setting for the default workergroup is setting disabled to
false.
Closes ray-project#537.
|
For reference, #543 implements the changes that were necessary on my end to get the chart working (really just a oneliner). |
|
Maybe it has something to do with Helm versions... |
DmitriGekhtman
pushed a commit
that referenced
this issue
Sep 7, 2022
This allows comparison between boolean types, i.e. see
ray-cluster/templates/raycluster-cluster.yaml:107, where we assert:
{{- if ne .Values.worker.disabled true }}
The default setting for the default workergroup is setting disabled to
false.
Closes #537.
This was referenced Sep 9, 2022
Closed
DmitriGekhtman
pushed a commit
that referenced
this issue
Sep 14, 2022
…tion on laptop (#563) It is used to reproduce the helm chart lint errors on GitHub Actions. If you cannot reproduce the errors on GitHub Actions, the possible reason is the difference versions of Helm. Issue #537 is an example that some errors only happen in old helm versions. Usage: Step1: Install ct (chart-testing) and related dependencies. See https://github.com/helm/chart-testing for more details. Step2: ./helm-chart/script/chart-test.sh
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this issue
Sep 24, 2023
…ject#543) This allows comparison between boolean types, i.e. see ray-cluster/templates/raycluster-cluster.yaml:107, where we assert: {{- if ne .Values.worker.disabled true }} The default setting for the default workergroup is setting disabled to false. Closes ray-project#537.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this issue
Sep 24, 2023
…tion on laptop (ray-project#563) It is used to reproduce the helm chart lint errors on GitHub Actions. If you cannot reproduce the errors on GitHub Actions, the possible reason is the difference versions of Helm. Issue ray-project#537 is an example that some errors only happen in old helm versions. Usage: Step1: Install ct (chart-testing) and related dependencies. See https://github.com/helm/chart-testing for more details. Step2: ./helm-chart/script/chart-test.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Search before asking
KubeRay Component
Others
What happened + What you expected to happen
Installing the helm chart from the current master via
the installation fails with:
This happens because the
disabledkey on the default worker group is undefined.Reproduction script
See above.
Anything else
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: