[Style] Fix golangci-lint rule: govet #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
force-pushed
the
feature/golangci-lint-govet
branch
from
06d4719
to
54a2277
Compare
kevin85421
reviewed
May 15, 2024
MortalHappiness
force-pushed
the
feature/golangci-lint-govet
branch
from
54a2277
to
322d5c5
Compare
Done. I've run |
MortalHappiness
force-pushed
the
feature/golangci-lint-govet
branch
from
322d5c5
to
9b32323
Compare
MortalHappiness
force-pushed
the
feature/golangci-lint-govet
branch
from
9b32323
to
3efe853
Compare
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
force-pushed
the
feature/golangci-lint-govet
branch
from
3efe853
to
e0d6026
Compare
kevin85421
approved these changes
Jun 24, 2024
| // Deprecated: This field is not used anymore. ref: https://github.com/ray-project/kuberay/issues/1685 | ||
| ServiceUnhealthySecondThreshold *int32 `json:"serviceUnhealthySecondThreshold,omitempty"` | ||
| // Deprecated: This field is not used anymore. ref: https://github.com/ray-project/kuberay/issues/1685 | ||
| DeploymentUnhealthySecondThreshold *int32 `json:"deploymentUnhealthySecondThreshold,omitempty"` | ||
| // ServeService is the Kubernetes service for head node and worker nodes who have healthy http proxy to serve traffics. | ||
| ServeService *corev1.Service `json:"serveService,omitempty"` | ||
| // Important: Run "make" to regenerate code after modifying this file |
There was a problem hiding this comment.
Maybe we can delete this line?
There was a problem hiding this comment.
Let's merge this PR for now. We can address this comment in any follow up PR.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Based on #2128, there are some rules that need manual fixing. This PR fixes the rule:
govetSee https://golangci-lint.run/usage/linters/ for details.
Related issue number
N/A
Checks