RayService: Omits Min and Max replicas from hash calculation #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would love to see this in the next release |
kpitzen
force-pushed
the
KP/RayServiceAutoscalingNoReplacement
branch
from
5e1d9e9
to
1918c4e
Compare
kpitzen
force-pushed
the
KP/RayServiceAutoscalingNoReplacement
branch
from
1918c4e
to
c992bd8
Compare
kevin85421
approved these changes
May 29, 2024
2 tasks
Open
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, when updating RayService config, changing MinReplicas or MaxReplicas in the autoscaling config triggers an entirely new RayCluster to be instantiated. In order to facilitate orchestrating canary deployments, we'd like to have the ability to scale those parameters on an existing cluster as we move traffic over.
Related issue number
Currently no issue linked, but I can create one if needed.
Checks