Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant log line that is failing golangci-lint #2366

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

andrewsykim
Copy link
Collaborator

Why are these changes needed?

golangci-lint is failing with this error:

apis/config/v1alpha1/config_utils_test.go:78:11: printf: non-constant format string in call to (*testing.common).Logf (govet)
			t.Logf(tt.name)
			       ^

This log line is not needed anyways since the test is wrapped with t.Run(tt.name, func(t *testing.T).

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
Copy link
Collaborator Author

@kevin85421

@andrewsykim
Copy link
Collaborator Author

FYI @MortalHappiness maybe this was introduced in #2362?

@andrewsykim
Copy link
Collaborator Author

Ah, I think #2300 and #2362 merged around the same time, so the the lint failure was ignored

@MortalHappiness
Copy link
Member

@andrewsykim Yes, this is due to #2300 is merged before #2362.

@kevin85421 kevin85421 merged commit fb7a486 into ray-project:master Sep 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants