[Feat][Kubectl-Plugin]Implement kubectl ray job submit #2394
+682
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Sep 21, 2024
|
|
||
| submissionMode := options.RayJob.Object["spec"].(map[string]interface{})["submissionMode"] | ||
| if submissionMode != nil { | ||
| if submissionMode == rayv1api.K8sJobMode || submissionMode == rayv1api.HTTPMode { |
There was a problem hiding this comment.
Probably safer to make this if submissionMode != rayv1api.UserMode in case we add more submission modes in the future
There was a problem hiding this comment.
Currently using "UserMode" string since the latest release does not have rayv1api.UserMode. Also added a check that returns an error if the ray job does not have submission mode since I did not see #2364 doing defaulting if submission mode is none.
| return fmt.Errorf("Failed to find service name: %w", err) | ||
| } | ||
|
|
||
| portForwardCmd := portforward.NewCmdPortForward(factory, *options.ioStreams) |
There was a problem hiding this comment.
Should there be some polling logic to wait for the RayCluster to be ready before we attempt the next step to port-forward and submit a job?
There was a problem hiding this comment.
You're right, we should. Adding check for cluster status.
chiayi
force-pushed
the
kubectl-plugin
branch
from
44d3abd
to
1de3354
Compare
chiayi
force-pushed
the
kubectl-plugin
branch
from
1de3354
to
d481253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements the
kubectl ray submit jobcommand.Related issue number
Checks